Skip to content

RFC First steps towards iterating over submodule refs

Jonathan Tan git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2refs: make _advance() check struct repo, not flagrefs.c refs/debug.c refs/files-backend.c +2 more+68 -438 replies
2/2refs: add repo paramater to _iterator_peel()refs.c refs/debug.c refs/files-backend.c +4 more+76 -330 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/2] First steps towards iterating over submodule refs

Here are more results from my submodule partial clone work - teaching ref iteration to work with submodules by introducing struct repo parameters at different points. I'm sending this out early as RFC (before implementing the part that actually adds support for other repositories) because there might be a better way to do this that I haven't thought of. (This patch set contains my best idea for how this could be implemented, but admittedly it is a bit unelegant that the repo parameter is injected differently into each iterator function.)

This will break any existing topic that introduces new ref store backends (Han-Wen cc-ed for reftable), although I think that the changes introduced here are not too significant.

Jonathan Tan (2):
refs: make _advance() check struct repo, not flag
refs: add repo paramater to _iterator_peel()

 refs.c                | 50 +++++++++++++++++++++++-------------------
 refs/debug.c          | 13 ++++++-----
 refs/files-backend.c  | 31 ++++++++++++++++++--------
 refs/iterator.c       | 38 ++++++++++++++++++++++++--------
 refs/packed-backend.c | 30 ++++++++++++++++---------
 refs/ref-cache.c      |  7 +++---
 refs/refs-internal.h  | 51 +++++++++++++++++++++++++++++--------------
 7 files changed, 144 insertions(+), 76 deletions(-)
Signature · 1 line
2.33.0.rc2.250.ged5fa647cd-goog