Skip to content

staging: rtl8723bs: remove lockdep warning

Fabio Aiuto linux-staging lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3staging: rtl8723bs: unwrap initialization of queuesdrivers/staging/rtl8723bs/core/rtw_ap.c drivers/staging/rtl8723bs/core/rtw_cmd.c drivers/staging/rtl8723bs/core/rtw_mlme.c +4 more+52 -260 replies
2/3staging: rtl8723bs: remove unnecessary parenthesesdrivers/staging/rtl8723bs/core/rtw_cmd.c+2 -20 replies
3/3staging: rtl8723bs: remove unused _rtw_init_queue() functiondrivers/staging/rtl8723bs/os_dep/osdep_service.c+0 -70 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchHans de Goede
SeriesR-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] staging: rtl8723bs: remove lockdep warning

This patchseries removes a lockdep warning that turned out to be a false positive.

All "lockable" queues in the driver are initialized by a single function. This confuses lockdep which puts all locks in the same unexistent class.

Fixed it by doing the initalization of queues in place.

Done a small code cleaning and removed the no more used function.

Tested-on: Lenovo ideapad Miix 300-10IBY

Fabio Aiuto (3):
staging: rtl8723bs: unwrap initialization of queues
staging: rtl8723bs: remove unnecessary parentheses
staging: rtl8723bs: remove unused _rtw_init_queue() function

 drivers/staging/rtl8723bs/core/rtw_ap.c       |  3 +-
 drivers/staging/rtl8723bs/core/rtw_cmd.c      |  3 +-
 drivers/staging/rtl8723bs/core/rtw_mlme.c     |  6 ++--
 drivers/staging/rtl8723bs/core/rtw_recv.c     | 12 ++++---
 drivers/staging/rtl8723bs/core/rtw_sta_mgt.c  | 15 ++++++---
 drivers/staging/rtl8723bs/core/rtw_xmit.c     | 33 ++++++++++++-------
 .../staging/rtl8723bs/hal/rtl8723bs_recv.c    |  6 ++--
 .../staging/rtl8723bs/os_dep/osdep_service.c  |  7 ----
 8 files changed, 52 insertions(+), 33 deletions(-)
Signature · 1 line
2.20.1