Skip to content

selftests/sgx: Oversubscription, page permission, thread entry

Reinette Chatre linux-kselftest linux-sgx lkml 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest13 patches 0 repliesNew
  2. v215 patches 8 repliesSuperseded
  3. v114 patches 16 repliesSuperseded

Changes in v3 from the cover letter

- Remove the non-kselftest placeholder patches while also removing their usage within the SGX selftests. Instead, the SGX selftests obtain needed data from CPUID directly (Dave).
- Rewrite commit message of "selftests/x86/sgx: Fix a benign linker warning" (Dave).
- Add Jarkko's signature to "selftests/sgx: Add page permission and exception test" (Jarkko).

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13selftests/x86/sgx: Fix a benign linker warningtools/testing/selftests/sgx/Makefile+1 -10 replies
2/13selftests/sgx: Assign source for each segmenttools/testing/selftests/sgx/load.c tools/testing/selftests/sgx/main.h tools/testing/selftests/sgx/sigstruct.c+8 -60 replies
3/13selftests/sgx: Make data measurement for an enclave segment optionaltools/testing/selftests/sgx/load.c tools/testing/selftests/sgx/main.h tools/testing/selftests/sgx/sigstruct.c+10 -30 replies
4/13selftests/sgx: Create a heap for the test enclavetools/testing/selftests/sgx/load.c tools/testing/selftests/sgx/main.c tools/testing/selftests/sgx/main.h+26 -90 replies
5/13selftests/sgx: Dump segments and /proc/self/maps only on failuretools/testing/selftests/sgx/main.c+12 -110 replies
6/13selftests/sgx: Encpsulate the test enclave creationtools/testing/selftests/sgx/main.c+26 -180 replies
7/13selftests/sgx: Move setup_test_encl() to each TEST_F()tools/testing/selftests/sgx/main.c+15 -40 replies
8/13selftests/sgx: Add a new kselftest: unclobbered_vdso_oversubscribedtools/testing/selftests/sgx/main.c+75 -00 replies
9/13selftests/sgx: Provide per-op parameter structs for the test enclavetools/testing/selftests/sgx/defines.h tools/testing/selftests/sgx/main.c tools/testing/selftests/sgx/test_encl.c+69 -460 replies
10/13selftests/sgx: Rename test properties in preparation for more enclave teststools/testing/selftests/sgx/defines.h tools/testing/selftests/sgx/main.c tools/testing/selftests/sgx/test_encl.c+26 -260 replies
11/13selftests/sgx: Add page permission and exception testtools/testing/selftests/sgx/defines.h tools/testing/selftests/sgx/main.c tools/testing/selftests/sgx/test_encl.c+169 -00 replies
12/13selftests/sgx: Enable multiple thread supporttools/testing/selftests/sgx/test_encl_bootstrap.S+14 -70 replies
13/13selftests/sgx: Add test for multiple TCS entrytools/testing/selftests/sgx/defines.h tools/testing/selftests/sgx/main.c tools/testing/selftests/sgx/test_encl.c+39 -00 replies

Reviews trailers per patch

All 13 patches have a Reviewed-by or Acked-by.

PatchJarkko SakkinenDave Hansen
1/13R-b A-b
2/13A-b
3/13A-b
4/13A-b
5/13A-b
6/13A-b
7/13A-b
8/13A-b
9/13A-b
10/13A-b A-b
11/13R-b A-b
12/13R-b A-b
13/13R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH V3 00/13] selftests/sgx: Oversubscription, page permission, thread entry

V2 available at:
https://lore.kernel.org/lkml/[email protected]/

Changes since V2:
- Remove the non-kselftest placeholder patches while also removing their usage within the SGX selftests. Instead, the SGX selftests obtain needed data from CPUID directly (Dave).
- Rewrite commit message of "selftests/x86/sgx: Fix a benign linker warning" (Dave).
- Add Jarkko's signature to "selftests/sgx: Add page permission and exception test" (Jarkko).

V1 available at:
https://lore.kernel.org/lkml/[email protected]/

Changes since V1:

- Biggest change: The non-kselftest placeholder patches included in this series that the kselftest work depends on are still being discussed elsewhere (link below) but has changed significantly since the first submission, warranting an update to the kselftest patches that depend on it.
Jarkko: I made significant modifications to your
"selftests/sgx: Add a new kselftest: unclobbered_vdso_oversubscribed" that you may want to look at.
- Improve cover letter and changelogs (Dave).
- Add Jarkko and Dave's signatures where obtained (Jarkko and Dave).
- Fix Cedric's signature in patch 1 (Jarkko and Cedric).
- Improve the loop locating the data segment (Jarkko).
- Update placeholder patches that makes the amount of SGX memory available to latest version (v8). Previously this dependency consisted out of one patch, now it spans two.

Hi Everybody,

This series consists out of outstanding SGX selftests changes, rebased and gathered in a single series that can easily be merged for testing and development, and a few more changes added to expand the existing tests.

The outstanding SGX selftest changes included in this series that have already been submitted separately are:

* A more than two year old patch fixing a benign linker warning that is still present today:
https://lore.kernel.org/linux-sgx/[email protected]/
The original patch is added intact and not all email addresses within are valid.

* Latest (v4) of Jarkko Sakkinen's series to add an oversubscription test:
https://lore.kernel.org/linux-sgx/[email protected]/

* Latest (v2) of Jarkko Sakkinen's patch that provides per-op parameter structs for the test enclave:
https://lore.kernel.org/linux-sgx/[email protected]/

The new changes introduced in this series builds on Jarkko's outstanding SGX selftest changes and adds new tests for page permissions, exception handling, and thread entry.

Building and running enclaves is painful and traditionally requires a big software stack. This adds features like threads to the SGX selftests which are traditionally implemented in that big software stack. This helps test SGX kernel support with only code from the kernel tree.

Reinette

Jarkko Sakkinen (8):
selftests/sgx: Assign source for each segment selftests/sgx: Make data measurement for an enclave segment optional selftests/sgx: Create a heap for the test enclave selftests/sgx: Dump segments and /proc/self/maps only on failure selftests/sgx: Encpsulate the test enclave creation selftests/sgx: Move setup_test_encl() to each TEST_F() selftests/sgx: Add a new kselftest: unclobbered_vdso_oversubscribed selftests/sgx: Provide per-op parameter structs for the test enclave

Reinette Chatre (4):
selftests/sgx: Rename test properties in preparation for more enclave
tests
selftests/sgx: Add page permission and exception test selftests/sgx: Enable multiple thread support selftests/sgx: Add test for multiple TCS entry

Sean Christopherson (1):
selftests/x86/sgx: Fix a benign linker warning

 tools/testing/selftests/sgx/Makefile          |   2 +-
 tools/testing/selftests/sgx/defines.h         |  33 +-
 tools/testing/selftests/sgx/load.c            |  40 +-
 tools/testing/selftests/sgx/main.c            | 357 +++++++++++++++---
 tools/testing/selftests/sgx/main.h            |   6 +-
 tools/testing/selftests/sgx/sigstruct.c       |  12 +-
 tools/testing/selftests/sgx/test_encl.c       |  60 ++-
 .../selftests/sgx/test_encl_bootstrap.S       |  21 +-
 8 files changed, 445 insertions(+), 86 deletions(-)
Signature · 1 line
2.25.1