RFC net: remove sk skb caches
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest5 patches 5 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | chtls: rename skb_entail() to chtls_skb_entail()drivers/ drivers/ drivers/ | +7 | 0 replies | |
| 2/5 | tcp: expose the tcp_mark_push() and skb_entail() helpersinclude/ net/ | +4 | 2 replies | |
| 3/5 | mptcp: stop relying on tcp_tx_skb_cachenet/ | +77 | 0 replies | |
| 4/5 | Partially revert "tcp: factor out tcp_build_frag()"include/ net/ | +51 | 2 replies | |
| 5/5 | tcp: remove sk_{tr}x_skb_cacheDocumentation/ include/ net/ +4 more | +0 | 0 replies |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by.
| Patch | Mat Martineau | Paolo Abeni |
|---|---|---|
| 1/5 | A-b | |
| 2/5 | A-b | |
| 3/5 | R-b | |
| 4/5 | A-b | |
| 5/5 | A-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC PATCH 0/5] net: remove sk skb caches
Eric noted we would be better off reverting the sk skb caches.
MPTCP relies on such a feature, so we need a little refactor of the MPTCP tx path before the mentioned revert.
The first patch avoids that the next one will cause a name clash. The second exposes additional TCP helpers. The 3rd patch changes the MPTCP code to do locally the whole skb allocation and updating, so it does not rely anymore on core TCP helpers for that nor the sk skb cache.
As a side effect, we can drop the tcp_build_frag helper.
Finally, we can pull Eric's revert.
Note that patch 3/5 will conflict with the pending -net fix for a recently reported syzkaller splat.
Eric Dumazet (1):
tcp: remove sk_{tr}x_skb_cache
Paolo Abeni (4):
chtls: rename skb_entail() to chtls_skb_entail()
tcp: expose the tcp_mark_push() and skb_entail() helpers
mptcp: stop relying on tcp_tx_skb_cache Partially revert "tcp: factor out tcp_build_frag()"
Documentation/networking/ip-sysctl.rst | 8 - .../chelsio/inline_crypto/chtls/chtls.h | 2 +- .../chelsio/inline_crypto/chtls/chtls_cm.c | 2 +- .../chelsio/inline_crypto/chtls/chtls_io.c | 10 +- include/net/sock.h | 19 --- include/net/tcp.h | 4 +- net/ipv4/af_inet.c | 4 - net/ipv4/sysctl_net_ipv4.c | 12 -- net/ipv4/tcp.c | 147 +++++++----------- net/ipv4/tcp_ipv4.c | 6 - net/ipv6/tcp_ipv6.c | 6 - net/mptcp/protocol.c | 137 +++++++++------- 12 files changed, 139 insertions(+), 218 deletions(-)
Signature · 1 line
2.26.3