Fix streaming on/off logic
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | media: dib0700: fix undefined behavior in tuner shutdowndrivers/ | +0 | 0 replies | |
| 2/3 | media: dib0700: cleanup start/stop streaming logicdrivers/ | +14 | 0 replies | |
| 3/3 | media: dib0700: Only touch one bit when start/stop an adapterdrivers/ | +1 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/3] Fix streaming on/off logic
As discussed on:
https://github.com/hselasky/webcamd/issues/16
the dib0700 had a regression on Kernel 2.6.39. Such regression didn't affect most devices, in practice, as it seems to happen only under certain circunstances.
Michael came up with a solution for the issue (already submitted to the ML) but let's take the opportunity to do a cleanup, as the resulting code was still touching both adapters when an stream off command was issued to one adapter, turning on the other one.
After the change, each adapter is idependently controlled by a separate bit, as can be shown when its debug message is turned on (tested on a dual-adapter device: Hauppauge WinTV Nova TD):
[608855.124780] adapter 1, streaming ON: 0f 10 12 [608868.189827] adapter 0, streaming ON: 0f 10 13 [608879.584330] adapter 1, streaming OFF: 0f 00 11 [608887.014772] adapter 0, streaming OFF: 0f 00 10
Mauro Carvalho Chehab (2):
media: dib0700: cleanup start/stop streaming logic
media: dib0700: Only touch one bit when start/stop an adapter
Michael Kuron (1):
media: dib0700: fix undefined behavior in tuner shutdown
drivers/media/usb/dvb-usb/dib0700_core.c | 28 +++++++++++------------- 1 file changed, 13 insertions(+), 15 deletions(-)
Signature · 1 line
2.31.1