Skip to content

devlink reload simplification

Leon Romanovsky linux-rdma lkml netdev 3 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest6 patches 0 repliesApplied 6/6
  2. v35 patches 3 repliesSuperseded
  3. v25 patches 17 repliesSuperseded

Changes in v4 from the cover letter

* Removed legacy BUG_ON() in first patch.
* Added new patch that moves netdev_to_devlink functions to devlink.c.
* Rewrote devlink ops patch to use feature mask.
v3: https://lore.kernel.org/all/[email protected]
* Rewrote third patch to keep static const nature of ops. This is done by extracting reload ops to separate ops structure.
* Changed commit message in last patch as was suggested by Ido.
v2: https://lore.kernel.org/all/[email protected]
* Dropped const removal patch
* Added new patch to hide struct devlink
* Added new patch to annotate devlink API
* Implemented copy of all callback in devlink ops
v1: https://lore.kernel.org/all/[email protected]
* Missed removal of extra WARN_ON
* Added "ops parameter to macro as Dan suggested.
v0: https://lore.kernel.org/all/[email protected]

Patches in v4 All 6 applied

#Subject and filesSizeRepliesApplied
1/6devlink: Reduce struct devlink exposuredrivers/net/ethernet/mellanox/mlxfw/mlxfw.h include/net/devlink.h include/trace/events/devlink.h +1 more+98 -870 repliesApplied
2/6devlink: Move netdev_to_devlink helpers to devlink.cinclude/net/devlink.h net/core/devlink.c+18 -170 repliesApplied
3/6devlink: Annotate devlink API callsnet/core/devlink.c+26 -00 repliesApplied
4/6devlink: Allow control devlink ops behavior through feature maskdrivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_devlink.c drivers/net/ethernet/mellanox/mlx4/main.c +5 more+34 -20 repliesApplied
5/6net/mlx5: Set devlink reload feature bit for supported devices onlydrivers/net/ethernet/mellanox/mlx5/core/devlink.c+4 -10 repliesApplied
6/6devlink: Delete reload enable/disable interfacedrivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_devlink.c drivers/net/ethernet/mellanox/mlx4/main.c +6 more+6 -690 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH net-next v4 0/6] devlink reload simplification

From: Leon Romanovsky <[email protected]>

Changelog:
v4:
* Removed legacy BUG_ON() in first patch.
* Added new patch that moves netdev_to_devlink functions to devlink.c.
* Rewrote devlink ops patch to use feature mask.
v3: https://lore.kernel.org/all/[email protected]
* Rewrote third patch to keep static const nature of ops. This is done by extracting reload ops to separate ops structure.
* Changed commit message in last patch as was suggested by Ido.
v2: https://lore.kernel.org/all/[email protected]
* Dropped const removal patch
* Added new patch to hide struct devlink
* Added new patch to annotate devlink API
* Implemented copy of all callback in devlink ops
v1: https://lore.kernel.org/all/[email protected]
* Missed removal of extra WARN_ON
* Added "ops parameter to macro as Dan suggested.
v0: https://lore.kernel.org/all/[email protected]

-------------------------------------------------------------------
Hi,

Simplify devlink reload APIs.

Thanks

Leon Romanovsky (6):
devlink: Reduce struct devlink exposure
devlink: Move netdev_to_devlink helpers to devlink.c
devlink: Annotate devlink API calls
devlink: Allow control devlink ops behavior through feature mask net/mlx5: Set devlink reload feature bit for supported devices only
devlink: Delete reload enable/disable interface

 .../hisilicon/hns3/hns3pf/hclge_devlink.c     |   4 +-
 .../hisilicon/hns3/hns3vf/hclgevf_devlink.c   |   4 +-
 drivers/net/ethernet/mellanox/mlx4/main.c     |   3 +-
 .../net/ethernet/mellanox/mlx5/core/devlink.c |   4 +
 .../net/ethernet/mellanox/mlx5/core/main.c    |   3 -
 .../mellanox/mlx5/core/sf/dev/driver.c        |   5 +-
 drivers/net/ethernet/mellanox/mlxfw/mlxfw.h   |   2 +-
 drivers/net/ethernet/mellanox/mlxsw/core.c    |   8 +-
 drivers/net/netdevsim/dev.c                   |   4 +-
 include/net/devlink.h                         |  79 ++-------
 include/trace/events/devlink.h                |  72 ++++----
 net/core/devlink.c                            | 164 +++++++++++++-----
 12 files changed, 181 insertions(+), 171 deletions(-)
Signature · 1 line
2.31.1