Skip to content

selftests: Improve nettest and net/fcnal-test.sh

Leonard Crestez linux-kselftest lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 18 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11selftests: net/fcnal: Fix {ipv4,ipv6}_bind not run by defaulttools/testing/selftests/net/fcnal-test.sh+2 -21 reply
2/11selftests: net/fcnal: Mark unknown -t or TESTS value as errortools/testing/selftests/net/fcnal-test.sh+3 -01 reply
3/11selftests: net/fcnal: Non-zero exit on failurestools/testing/selftests/net/fcnal-test.sh+1 -01 reply
4/11selftests: net/fcnal: Use accept_dad=0 to avoid setup sleeptools/testing/selftests/net/fcnal-test.sh+7 -101 reply
5/11selftests: net/fcnal: kill_procs via spin instead of sleeptools/testing/selftests/net/fcnal-test.sh+9 -22 replies
6/11selftests: net/fcnal: Do not capture do_run_cmd in verbose modetools/testing/selftests/net/fcnal-test.sh+7 -91 reply
7/11selftests: nettest: Implement -k to fork after bind or listentools/testing/selftests/net/nettest.c+33 -10 replies
8/11selftests: net/fcnal: Replace sleep after server start with -ktools/testing/selftests/net/fcnal-test.sh+219 -4224 replies
9/11selftests: nettest: Convert timeout to milisecondstools/testing/selftests/net/nettest.c+41 -111 reply
10/11selftests: nettest: Add NETTEST_CLIENT,SERVER}_TIMEOUT envvarstools/testing/selftests/net/nettest.c+54 -121 reply
11/11selftests: net/fcnal: Reduce client timeouttools/testing/selftests/net/fcnal-test.sh+11 -65 replies

Reviews trailers per patch

6 of 11 patches have a Reviewed-by or Acked-by.

PatchDavid Ahern
1/11R-b
2/11R-b
3/11R-b
4/11R-b
5/11
6/11R-b
7/11
8/11
9/11R-b
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/11] selftests: Improve nettest and net/fcnal-test.sh

This is a series of improvements to nettest and fcnal-test.sh from tools/testing/selftests/net which make tests run faster. For me this reduces the runtime from ~40minutes to ~5minutes and makes the tcp tests very fast.

Some of the early commits are outright bugfixes.

The tests DO NOT pass perfectly for me on latest net-next/master but I verified that the failures also happen without my changes. Here is the list of failures:

TEST: ping local, VRF bind - VRF IP [FAIL]
TEST: Raw socket bind to local address - VRF IP [FAIL]
TEST: ping out, VRF bind - ns-B IPv6 LLA [FAIL]
TEST: ping out, VRF bind - multicast IP [FAIL]
TEST: TCP socket bind to out of scope local address - ns-A loopback IPv6 [FAIL]
TEST: TCP socket bind to VRF address with device bind - VRF IPv6 [FAIL]

Three of those were not tested by default before my changes, only with explicit -t 'bind bind6'

This is related to my work on TCP-AO but there are no patch dependencies

Leonard Crestez (11):
selftests: net/fcnal: Fix {ipv4,ipv6}_bind not run by default
selftests: net/fcnal: Mark unknown -t or TESTS value as error
selftests: net/fcnal: Non-zero exit on failures
selftests: net/fcnal: Use accept_dad=0 to avoid setup sleep
selftests: net/fcnal: kill_procs via spin instead of sleep
selftests: net/fcnal: Do not capture do_run_cmd in verbose mode
selftests: nettest: Implement -k to fork after bind or listen
selftests: net/fcnal: Replace sleep after server start with -k
selftests: nettest: Convert timeout to miliseconds
selftests: nettest: Add NETTEST_CLIENT,SERVER}_TIMEOUT envvars
selftests: net/fcnal: Reduce client timeout

 tools/testing/selftests/net/fcnal-test.sh | 710 ++++++++--------------
 tools/testing/selftests/net/nettest.c     | 134 +++-
 2 files changed, 378 insertions(+), 466 deletions(-)

base-commit: 0693b27644f04852e46f7f034e3143992b658869

Signature · 1 line
2.25.1