Skip to content

Update device mod time fixes

Josef Bacik linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest2 patches 3 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2fs: export an inode_update_time helperfs/inode.c include/linux/fs.h+6 -33 replies
2/2btrfs: update device path inode time instead of bd_inodefs/btrfs/volumes.c+13 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] Update device mod time fixes

Hello,

Christoph noticed that my original fix to stop calling filp_open() when we remove devices was wrong because ->bd_inode isn't the inode we need to be update, it needs to be the inode that is associated with the path to the device node.

In order to do this I need to do a kern_path() to lookup the path to that inode, and then I need to update the time for that inode. generic_update_time() isn't appropriate here as it should be used by ->update_time() if at all. Instead export a inode_update_time() helper to do the correct thing, and use that.

This allows us to update the time properly for libblkid, and makes sure we still have the lockdep fix that was the motivation of the original fix. Thanks,

Josef Bacik (2):
fs: export an inode_update_time helper
btrfs: update device path inode time instead of bd_inode

 fs/btrfs/volumes.c | 21 +++++++++++++--------
 fs/inode.c         |  7 ++++---
 include/linux/fs.h |  2 ++
 3 files changed, 19 insertions(+), 11 deletions(-)
Signature · 1 line
2.26.3