provide fsid in sysfs devinfo
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest2 patches 10 repliesIn review
- v12 patches 10 repliesSuperseded
Changes in v2 from the cover letter
Fix sysfs_emit conversion at the two non-sysfs show functions in patch1.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | btrfs: sysfs convert scnprintf and snprintf to use sysfs_emitfs/ | +46 | 4 replies | |
| 2/2 | btrfs: sysfs add devinfo/fsid to retrieve fsid from the devicefs/ | +11 | 5 replies |
Reviews trailers per patch
1 of 2 patches has a Reviewed-by or Acked-by.
| Patch | Josef Bacik |
|---|---|
| 1/2 | |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/2] provide fsid in sysfs devinfo
v2:
Fix sysfs_emit conversion at the two non-sysfs show functions in patch1.
btrfs-progs tries to read the fsid from the super-block for a missing device and, it fails. It needs to find out if the device is a seed device. It does it by comparing the device's fsid with the fsid of the mounted filesystem. To help this scenario introduce a new sysfs file to read the fsid from the kernel.
/sys/fs/btrfs/<fsid>/devinfo/<devid>/fsid
Patch 1 is a cleanup converts scnprtin()f and snprintf() to sysfs_emit() Patch 2 introduces the new sysfs interface as above
The other implementation choice is to add another parameter to the struct btrfs_ioctl_dev_info_args and use BTRFS_IOC_DEV_INFO ioctl. But then backward kernel compatibility with the newer btrfs-progs is more complicated. If needed, we can add that too.
Related btrfs-progs patches:
btrfs-progs: prepare helper device_is_seed
btrfs-progs: read fsid from the sysfs in device_is_seed
Anand Jain (2):
btrfs: sysfs convert scnprintf and snprintf to use sysfs_emit
btrfs: sysfs add devinfo/fsid to retrieve fsid from the device
fs/btrfs/sysfs.c | 106 +++++++++++++++++++++++++---------------------- 1 file changed, 57 insertions(+), 49 deletions(-)
Signature · 1 line
2.31.1