Skip to content

staging: vt6655: Fix line wrapping in `RFvWriteWakeProgSyn`

Karolina Drobnik linux-staging lkml outreachy 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest8 patches 1 replyIn review
  2. v28 patches 10 repliesSuperseded
  3. v17 patches 14 repliesSuperseded

Changes in v3 from the cover letter

* add a patch for removing the type cast as a first change, suggested by Dan Carpenter <[email protected]>
* merge two patches (using incrementation in idx and cleanup) into one, partially implementing Dan's suggestion

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8staging: vt6655: Remove unnecessary type castsdrivers/staging/vt6655/rf.c+8 -80 replies
2/8staging: vt6655: Introduce `idx` variabledrivers/staging/vt6655/rf.c+9 -80 replies
3/8staging: vt6655: Use incrementation in `idx`drivers/staging/vt6655/rf.c+8 -110 replies
4/8staging: vt6655: Rewrite conditional in AL7320 initializationdrivers/staging/vt6655/rf.c+5 -70 replies
5/8staging: vt6655: Rename `RFvWriteWakeProgSyn` functiondrivers/staging/vt6655/channel.c drivers/staging/vt6655/rf.c drivers/staging/vt6655/rf.h+4 -40 replies
6/8staging: vt6655: Update comment for `rf_write_wake_prog_syn`drivers/staging/vt6655/rf.c+4 -40 replies
7/8staging: vt6655: Delete bogus check for `init_count` in AL2230drivers/staging/vt6655/rf.c+0 -20 replies
8/8staging: vt6655: Delete bogus check for `init_count` in AL7230drivers/staging/vt6655/rf.c+0 -20 replies

Reviews trailers per patch

None of the 8 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDan Carpenter
SeriesR-b
1/8
2/8
3/8
4/8
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/8] staging: vt6655: Fix line wrapping in `RFvWriteWakeProgSyn`

This patch set is a series of small refactorings of the function RFvWriteWakeProgSyn, now renamed to rf_write_wake_prog_syn. The work here allowed to shorten lines marked by checkpatch.pl as being too long by:
* introducing two new temporary variables (idx and init_table)
* rewriting a conditional to switch between two modes of AL7320 initialization.

In addition to this, the patch set renames the function to align it with the kernel coding style, updates the function description and removes two unnecessary conditionals checking if the value of init_count is lower than a predefined value.

Changes in v3:
* add a patch for removing the type cast as a first change, suggested by Dan Carpenter <[email protected]>
* merge two patches (using incrementation in idx and cleanup) into one, partially implementing Dan's suggestion

Changes in v2:
* drop "staging: vt6655: Introduce data temporary variable" patch, suggested by Julia Lawall <[email protected]>
* amend "staging: vt6655: Rewrite conditional in AL7320 initialization" patch to use indexing and init_table temporary variable
* add two new patches to remove unnecessary checks for init count, suggested by Mike Rapoport <[email protected]>:
- "staging: vt6655: Delete bogus check for init_count in AL2230"
- "staging: vt6655: Delete bogus check for init_count in AL7230"

Karolina Drobnik (8):
staging: vt6655: Remove unnecessary type casts
staging: vt6655: Introduce idx variable
staging: vt6655: Use incrementation in idx
staging: vt6655: Rewrite conditional in AL7320 initialization
staging: vt6655: Rename RFvWriteWakeProgSyn function
staging: vt6655: Update comment for rf_write_wake_prog_syn
staging: vt6655: Delete bogus check for init_count in AL2230
staging: vt6655: Delete bogus check for init_count in AL7230

 drivers/staging/vt6655/channel.c |  2 +-
 drivers/staging/vt6655/rf.c      | 44 +++++++++++++-------------------
 drivers/staging/vt6655/rf.h      |  2 +-
 3 files changed, 20 insertions(+), 28 deletions(-)
Signature · 1 line
2.30.2