Address issues preventing camorama to work with atomisp
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest7 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | media: atomisp-ov2680: use v4l2_find_nearest_size()drivers/ drivers/ | +25 | 0 replies | |
| 2/7 | media: atomisp: move a debug printf to a better placedrivers/ | +4 | 0 replies | |
| 3/7 | media: atomisp: fix VIDIOC_S_FMT logicdrivers/ | +44 | 0 replies | |
| 4/7 | media: atomisp: fix enum_fmt logicdrivers/ | +5 | 0 replies | |
| 5/7 | media: atomisp: move atomisp_g_fmt_cap()drivers/ | +28 | 0 replies | |
| 6/7 | media: atomisp: fix try_fmt logicdrivers/ drivers/ | +71 | 0 replies | |
| 7/7 | media: atomisp: fix g_fmt logicdrivers/ | +7 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/7] Address issues preventing camorama to work with atomisp
This patch series address some issues at atomisp that are preventing camorama to work with atomisp driver.
After this series, I can use camorama just like on any other device. The frame rate is slow (~7fps), though. Not sure if this is due to some sensor limitation or because of some other issue.
Anyway this is a start :-)
Some notes:
1. Patch 1 fixes an issue at ov2680 logic. It probably needs to be reflected at the other supported sensors;
2. MMAP is not working. So, it requires a newer version of camorama that has support for USERPTR.
3. There's nothing special on Camorama for atomisp, except that it has support for USERPTR.
4. Camorama currently doesn't allow changing the resolution of the camera. That's because of several things:
a. The driver has a scaler, supporting resolutions from 32x16 to 1600x1200
on Asus T101HA.
b. The atomisp driver doesn't implement ENUM_FRAMEINTERVALS;
c. camorama is not prepared for cameras with scalers on it. It just lets one to
select the resolutions enumerated by ENUM_FRAMEINTERVALS.
Mauro Carvalho Chehab (7):
media: atomisp-ov2680: use v4l2_find_nearest_size()
media: atomisp: move a debug printf to a better place
media: atomisp: fix VIDIOC_S_FMT logic
media: atomisp: fix enum_fmt logic
media: atomisp: move atomisp_g_fmt_cap()
media: atomisp: fix try_fmt logic
media: atomisp: fix g_fmt logic
.../media/atomisp/i2c/atomisp-ov2680.c | 127 +++----------- drivers/staging/media/atomisp/i2c/ov2680.h | 3 +- .../staging/media/atomisp/pci/atomisp_cmd.c | 59 +++++-- .../staging/media/atomisp/pci/atomisp_ioctl.c | 157 ++++++++++-------- 4 files changed, 162 insertions(+), 184 deletions(-)
Signature · 1 line
2.31.1