atomisp: add support for enum frame rate and sizes
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | media: atomisp-ov2680: implement enum frame intervalsdrivers/ | +21 | 0 replies | |
| 2/3 | media: atomisp-ov2680: adjust the maximum frame ratedrivers/ | +7 | 0 replies | |
| 3/3 | media: atomisp: implement enum framesize/frameintervaldrivers/ | +53 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/3] atomisp: add support for enum frame rate and sizes
Adding support for those two ioctls are trivial, and allow testing different resolutions with the driver.
Together with some improvements I made at camorama, it is now possible to change the atomisp sensor's resolution at the GUI.
Talking about camorama, I also added there an option to disable the Gtk cairo_scale() calls. On my tests here, placing ov2680 on its maximum resolution, I'm getting a framerate of 26 fps, which sounds reasonable, as the maximum would be 30fps, and I'm not using daylight.
When letting cairo_scale() to run, the rate reduces to 8 fps, meaning that Gtk is not using GPU acceleration.
Funny enough, when resolution is lower, atomisp is giving a very bad framerate (around 3fps, even with the scaler disabled).
This is a very weird result, probably indicating some problems inside the driver. That requires further investigation.
Mauro Carvalho Chehab (3):
media: atomisp-ov2680: implement enum frame intervals
media: atomisp-ov2680: adjust the maximum frame rate
media: atomisp: implement enum framesize/frameinterval
.../media/atomisp/i2c/atomisp-ov2680.c | 21 ++++++++ drivers/staging/media/atomisp/i2c/ov2680.h | 14 ++--- .../staging/media/atomisp/pci/atomisp_ioctl.c | 53 +++++++++++++++++++ 3 files changed, 81 insertions(+), 7 deletions(-)
Signature · 1 line
2.33.1