Skip to content

mptcp: improve subflow creation on errors

Paolo Abeni mptcp 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest7 patches 5 repliesIn review
  2. v55 patches 4 repliesSuperseded
  3. v45 patches 7 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v2 posting 2/24 patches5 repliesSuperseded
v2 posting 1/24 patches3 repliesSuperseded
v13 patches8 repliesSuperseded

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7mptcp: fix per socket endpoint accounting.net/mptcp/pm_netlink.c+12 -60 replies
2/7mptcp: clean-up MPJ option writing.net/mptcp/options.c+23 -210 replies
3/7mptcp: keep track of local endpoint still available for each msknet/mptcp/pm.c net/mptcp/pm_netlink.c net/mptcp/protocol.c +2 more+86 -500 replies
4/7mptcp: do not block subflows creation on errorsnet/mptcp/pm.c net/mptcp/pm_netlink.c net/mptcp/protocol.c +1 more+71 -310 replies
5/7selftests: mptcp: add tests for subflow creation failuretools/testing/selftests/net/mptcp/config tools/testing/selftests/net/mptcp/mptcp_join.sh+78 -11 reply
6/7mptcp: cleanup MPJ subflow list handlingnet/mptcp/pm_netlink.c net/mptcp/protocol.c net/mptcp/protocol.h +2 more+56 -1000 replies
7/7mptcp: avoid atomic bit manipulation when possiblenet/mptcp/protocol.c net/mptcp/protocol.h net/mptcp/subflow.c+37 -312 replies

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMat Martineau
SeriesR-b
1/7
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 mptcp-next 0/7] mptcp: improve subflow creation on errors

This iteration tries to add address the feedback on v5, namely test counter update and locking in write_options. The latter required quite significant changes in patch 5/7.

Additionally the series now includes the pending cleanup, as they depends on the previous patches. No changes there WRT the previous iteration.

Currently when a subflow connection fails - either the TCP connection is reset by the peer, or the MPJ handshake never completes - the in kernel PM don't perform any further action. Notably no additional subflow creation is attempted.

This series is aimed at improving the in-kernel path manager behavior in the above scenario:
- each endpoint is used only once per connection (patch 2/4)
- on failure we try to move to the next subflow, if any (patch 3/4)

The first patch is minor cleanup, and the last patch adds specific self-tests.

This should address/close:
https://github.com/multipath-tcp/mptcp_net-next/issues/235
https://github.com/multipath-tcp/mptcp_net-next/issues/242

Paolo Abeni (7):
mptcp: fix per socket endpoint accounting.
mptcp: clean-up MPJ option writing.
mptcp: keep track of local endpoint still available for each msk
mptcp: do not block subflows creation on errors
selftests: mptcp: add tests for subflow creation failure
mptcp: cleanup MPJ subflow list handling
mptcp: avoid atomic bit manipulation when possible

 net/mptcp/options.c                           |  44 ++--
 net/mptcp/pm.c                                |  24 ++-
 net/mptcp/pm_netlink.c                        | 188 +++++++++++-------
 net/mptcp/protocol.c                          | 158 +++++++--------
 net/mptcp/protocol.h                          |  46 +++--
 net/mptcp/sockopt.c                           |  24 +--
 net/mptcp/subflow.c                           |   9 +-
 tools/testing/selftests/net/mptcp/config      |   1 +
 .../testing/selftests/net/mptcp/mptcp_join.sh |  83 +++++++-
 9 files changed, 350 insertions(+), 227 deletions(-)
Signature · 1 line
2.33.1