mptcp: improve subflow creation on errors
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest7 patches 5 repliesIn review
- v55 patches 4 repliesSuperseded
- v45 patches 7 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 posting 2/2 | 4 patches | 5 replies | Superseded | |
| v2 posting 1/2 | 4 patches | 3 replies | Superseded | |
| v1 | 3 patches | 8 replies | Superseded |
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | mptcp: fix per socket endpoint accounting.net/ | +12 | 0 replies | |
| 2/7 | mptcp: clean-up MPJ option writing.net/ | +23 | 0 replies | |
| 3/7 | mptcp: keep track of local endpoint still available for each msknet/ net/ net/ +2 more | +86 | 0 replies | |
| 4/7 | mptcp: do not block subflows creation on errorsnet/ net/ net/ +1 more | +71 | 0 replies | |
| 5/7 | selftests: mptcp: add tests for subflow creation failuretools/ tools/ | +78 | 1 reply | |
| 6/7 | mptcp: cleanup MPJ subflow list handlingnet/ net/ net/ +2 more | +56 | 0 replies | |
| 7/7 | mptcp: avoid atomic bit manipulation when possiblenet/ net/ net/ | +37 | 2 replies |
Reviews trailers per patch
None of the 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Mat Martineau |
|---|---|
| Series | R-b |
| 1/7 | |
| 2/7 | |
| 3/7 | |
| 4/7 | |
| 5/7 | |
| 6/7 | |
| 7/7 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v6 mptcp-next 0/7] mptcp: improve subflow creation on errors
This iteration tries to add address the feedback on v5, namely test counter update and locking in write_options. The latter required quite significant changes in patch 5/7.
Additionally the series now includes the pending cleanup, as they depends on the previous patches. No changes there WRT the previous iteration.
Currently when a subflow connection fails - either the TCP connection is reset by the peer, or the MPJ handshake never completes - the in kernel PM don't perform any further action. Notably no additional subflow creation is attempted.
This series is aimed at improving the in-kernel path manager behavior in the above scenario:
- each endpoint is used only once per connection (patch 2/4)
- on failure we try to move to the next subflow, if any (patch 3/4)
The first patch is minor cleanup, and the last patch adds specific self-tests.
This should address/close:
https://github.com/multipath-tcp/mptcp_net-next/issues/235
https://github.com/multipath-tcp/mptcp_net-next/issues/242
Paolo Abeni (7):
mptcp: fix per socket endpoint accounting.
mptcp: clean-up MPJ option writing.
mptcp: keep track of local endpoint still available for each msk
mptcp: do not block subflows creation on errors
selftests: mptcp: add tests for subflow creation failure
mptcp: cleanup MPJ subflow list handling
mptcp: avoid atomic bit manipulation when possible
net/mptcp/options.c | 44 ++-- net/mptcp/pm.c | 24 ++- net/mptcp/pm_netlink.c | 188 +++++++++++------- net/mptcp/protocol.c | 158 +++++++-------- net/mptcp/protocol.h | 46 +++-- net/mptcp/sockopt.c | 24 +-- net/mptcp/subflow.c | 9 +- tools/testing/selftests/net/mptcp/config | 1 + .../testing/selftests/net/mptcp/mptcp_join.sh | 83 +++++++- 9 files changed, 350 insertions(+), 227 deletions(-)
Signature · 1 line
2.33.1