Skip to content

Cleanup and optimize a few bitmap operations

Christophe JAILLET kernel-janitors linux-rdma lkml 1 version Applied

Status from this message: Applied to for-next, thanks

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3RDMA/cxgb4: Use bitmap_zalloc() when applicabledrivers/infiniband/hw/cxgb4/id_table.c+3 -50 replies
2/3RDMA/cxgb4: Use bitmap_set() when applicabledrivers/infiniband/hw/cxgb4/id_table.c+1 -40 replies
3/3RDMA/cxgb4: Use non-atomic bitmap functions when possibledrivers/infiniband/hw/cxgb4/id_table.c+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Cleanup and optimize a few bitmap operations

Patch 1 and 2 are just cleanups that uses 'bitmap_zalloc()' and 'bitmap_set()' instead of hand-writing these functions.

Patch 3 is more questionable. It replaces calls to '[set|clear]_bit()' by their non-atomic '__[set|clear]_bit()' alternatives.
It looks safe to do so because accesses to the corresponding bitmaps are protected by spinlocks.
However, this patch is compile-tested only. It is not sure that it worth changing the code just for saving a few atomic operations.
So review, test and apply only if it make sense.

Christophe JAILLET (3):
RDMA/cxgb4: Use bitmap_zalloc() when applicable RDMA/cxgb4: Use bitmap_set() when applicable RDMA/cxgb4: Use non-atomic bitmap functions when possible

 drivers/infiniband/hw/cxgb4/id_table.c | 17 ++++++-----------
 1 file changed, 6 insertions(+), 11 deletions(-)
Signature · 1 line
2.30.2