Skip to content

reworking io_uring's poll and internal poll

Pavel Begunkov io-uring 1 version Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 3 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/7io_uring: remove double poll on poll updatefs/io_uring.c+1 -00 replies
2/7io_uring: refactor poll updatefs/io_uring.c+26 -360 replies
3/7io_uring: move common poll bitsfs/io_uring.c+37 -370 replies
4/7io_uring: kill poll linking optimisationfs/io_uring.c+2 -60 replies
5/7io_uring: poll reworkfs/io_uring.c+227 -2990 replies
6/7io_uring: single shot poll removal optimisationfs/io_uring.c+7 -10 replies
7/7io_uring: use completion batching for poll rem/updfs/io_uring.c+7 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH for-next 0/7] reworking io_uring's poll and internal poll

That's mostly a bug fixing set, some of the problems are listed in 5/7. The main part is 5/7, which is bulky but at this point it's hard (if possible) to do anything without breaking a dozen of things on the way, so I consider it necessary evil.
It also addresses one of two problems brought up by Eric Biggers for aio, specifically poll rewait. There is no poll-free support yet.

As a side effect it also changes performance characteristics, adding extra atomics but removing io_kiocb referencing, improving rewait, etc. There are also drafts on optimising locking needed for hashing, those will go later.

Performance measurements is a TODO, but the main goal lies in correctness and maintainability.

Pavel Begunkov (7):
io_uring: remove double poll on poll update
io_uring: refactor poll update
io_uring: move common poll bits
io_uring: kill poll linking optimisation
io_uring: poll rework
io_uring: single shot poll removal optimisation
io_uring: use completion batching for poll rem/upd

 fs/io_uring.c | 649 ++++++++++++++++++++++----------------------------
 1 file changed, 287 insertions(+), 362 deletions(-)
Signature · 1 line
2.34.0