Skip to content

staging: vc04_services: avoid the use of typedef for function pointers

Gaston Gonzalez linux-arm-kernel linux-staging lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 2 repliesIn review
  2. v14 patches 7 repliesSuperseded

Changes in v2 from the cover letter

- Following Greg suggestion, functions pointers were not renamed making patches 1 and 2 much smaller.
- Function pointers in vchiq-mmal were not touched as the result is less readable than the original.
- In the description of changes in the TODO file, it was specified that there are no current 'struct typedefs' left inside vc04_servivces.
- The name of the particular subsystem of vc04_services was included in the title of each commit.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3staging: vc04_services: bcm2835-audio: avoid the use of typedef for function pointersdrivers/staging/vc04_services/bcm2835-audio/bcm2835.c+3 -90 replies
2/3staging: vc04_services: bcm2835-camera: avoid the use of typedef for function pointersdrivers/staging/vc04_services/bcm2835-camera/controls.c+2 -80 replies
3/3staging: vc04_services: update TODO filedrivers/staging/vc04_services/interface/TODO+2 -61 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] staging: vc04_services: avoid the use of typedef for function pointers

This patch set removes some typedefs for function pointers in vc04_services.

v1 -> v2:

- Following Greg suggestion, functions pointers were not renamed making patches 1 and 2 much smaller.
- Function pointers in vchiq-mmal were not touched as the result is less readable than the original.
- In the description of changes in the TODO file, it was specified that there are no current 'struct typedefs' left inside vc04_servivces.
- The name of the particular subsystem of vc04_services was included in the title of each commit.

Gaston Gonzalez (3):
staging: vc04_services: bcm2835-audio: avoid the use of typedef for
function pointers
staging: vc04_services: bcm2835-camera: avoid the use of typedef for
function pointers
staging: vc04_services: update TODO file

 .../staging/vc04_services/bcm2835-audio/bcm2835.c    | 12 +++---------
 .../staging/vc04_services/bcm2835-camera/controls.c  | 10 ++--------
 drivers/staging/vc04_services/interface/TODO         |  8 ++------
 3 files changed, 7 insertions(+), 23 deletions(-)
Signature · 1 line
2.34.1