Rework realtek-rtl IRQ driver
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest6 patches 4 repliesIn review
- v2 RFC5 patches 13 repliesSuperseded
- v1 RFC4 patches 6 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | irqchip/realtek-rtl: map control data to virqdrivers/ | +1 | 0 replies | |
| 2/6 | irqchip/realtek-rtl: fix off-by-one in routingdrivers/ | +5 | 0 replies | |
| 3/6 | irqchip/realtek-rtl: clear all pending interruptsdrivers/ | +6 | 0 replies | |
| 4/6 | dt-bindings: interrupt-controller: realtek,rtl-intc: require parentsDocumentation/ | +58 | 3 replies | |
| 5/6 | irqchip/realtek-rtl: use parent interruptsdrivers/ | +61 | 0 replies | |
| 6/6 | irqchip/realtek-rtl: use per-parent domainsdrivers/ | +124 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.
Cover letter [PATCH v3 0/6] Rework realtek-rtl IRQ driver
After seeing some use, and with more devices tested, the current implementation for the Realtek SoC interrupt controller was found to contain a few flaws.
The driver requires the following fixes:
- irq_domain_ops::map should map the virq, not the hwirq
- routing has an off-by-one error. Routing values (1..6) correspond to MIPS CAUSEF(2..7)
The following improvements should also be made:
- Use N real cascaded interrupts with an interrupt-specific mask of child irq lines. Otherwise a high-priority interrupt may cause a low-priority interrupt to be handled first.
- Get rid of assumed routing to parent interrupts of the original implementation.
Changes since v2 (RFC):
- Define new, two-part compatibles for devicetree bindings. The existing format is kept for the old one-part compatible, but deprecated. New compatibles will require a different way of specifying parent interrupts and interrupt routing.
- Add change to handle all pending SoC interrupts in one go.
Changes since v1 (RFC):
- Split some of the changes to limit the patch scope to one issue.
- Dropped some small (spurious or unneeded) changes
- Instead of dropping/replacing interrupt-map, the last patches now provide an implementation that amends the current situtation.
Sander Vanheule (6):
irqchip/realtek-rtl: map control data to virq irqchip/realtek-rtl: fix off-by-one in routing irqchip/realtek-rtl: clear all pending interrupts
dt-bindings: interrupt-controller: realtek,rtl-intc: require parents irqchip/realtek-rtl: use parent interrupts irqchip/realtek-rtl: use per-parent domains
.../realtek,rtl-intc.yaml | 78 ++++-- drivers/irqchip/irq-realtek-rtl.c | 235 ++++++++++++------ 2 files changed, 222 insertions(+), 91 deletions(-)
Signature · 1 line
2.33.1