Skip to content

pinctrl: renesas: checker: Miscellaneous improvements

Geert Uytterhoeven linux-gpio linux-renesas-soc 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10pinctrl: renesas: Remove unused pfc parameter from .pin_to_pocctrl()drivers/pinctrl/renesas/pfc-r8a77470.c drivers/pinctrl/renesas/pfc-r8a7790.c drivers/pinctrl/renesas/pfc-r8a7791.c +12 more+16 -250 replies
2/10pinctrl: renesas: Factor out .pin_to_portcr() address handlingdrivers/pinctrl/renesas/pfc-r8a73a4.c drivers/pinctrl/renesas/pfc-r8a7740.c drivers/pinctrl/renesas/pfc-sh73a0.c +2 more+12 -100 replies
3/10pinctrl: renesas: Pass sh_pfc_soc_info to rcar_pin_to_bias_reg()drivers/pinctrl/renesas/pfc-r8a77995.c drivers/pinctrl/renesas/pinctrl.c drivers/pinctrl/renesas/sh_pfc.h+9 -90 replies
4/10pinctrl: renesas: checker: Simplify same_name()drivers/pinctrl/renesas/core.c+1 -40 replies
5/10pinctrl: renesas: checker: Add pin group sharing checksdrivers/pinctrl/renesas/core.c+32 -50 replies
6/10pinctrl: renesas: checker: Validate bias configs consistencydrivers/pinctrl/renesas/core.c+73 -70 replies
7/10pinctrl: renesas: checker: Validate drive strength configs consistencydrivers/pinctrl/renesas/core.c+29 -10 replies
8/10pinctrl: renesas: checker: Validate I/O voltage configs consistencydrivers/pinctrl/renesas/core.c+14 -00 replies
9/10pinctrl: renesas: checker: Check bias pin conflictsdrivers/pinctrl/renesas/core.c+22 -00 replies
10/10pinctrl: renesas: checker: Check drive pin conflictsdrivers/pinctrl/renesas/core.c+20 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/10] pinctrl: renesas: checker: Miscellaneous improvements

Hi Linus,

This patch series improves the Renesas pin control table validator (enabled when DEBUG is defined, e.g. with CONFIG_DEBUG_PINCTRL=y), by:
1. Suggesting which pin groups can share pins,
2. Adding more checks to catch common errors.

If you enable the checker, you may be disappointed by the (lack of) output. Indeed, it is much easier to fix detected issues, than to get the checker code in a state that is suitable for upstream submission ;-)
Hence most issues detected have been fixed already for quite some time, or never arrived upstream in the first place. Recent fixes are [1] and [2].

If accepted, I intend to queue this in renesas-pinctrl for v5.18. Thanks for your comments!

[1] "[PATCH 00/60] pinctrl: renesas: Share more pin group data"

    https://lore.kernel.org/r/[email protected]/
[2] "[PATCH] pinctrl: renesas: r8a7794: Add range checking to
     .pin_to_pocctrl()"
    https://lore.kernel.org/r/d23767ad7152327654192d7191f4b8ae19493966.1640269510.git.geert+renesas@glider.be/

Geert Uytterhoeven (10):
pinctrl: renesas: Remove unused pfc parameter from .pin_to_pocctrl()
pinctrl: renesas: Factor out .pin_to_portcr() address handling
pinctrl: renesas: Pass sh_pfc_soc_info to rcar_pin_to_bias_reg()
pinctrl: renesas: checker: Simplify same_name()
pinctrl: renesas: checker: Add pin group sharing checks
pinctrl: renesas: checker: Validate bias configs consistency
pinctrl: renesas: checker: Validate drive strength configs consistency
pinctrl: renesas: checker: Validate I/O voltage configs consistency
pinctrl: renesas: checker: Check bias pin conflicts
pinctrl: renesas: checker: Check drive pin conflicts

 drivers/pinctrl/renesas/core.c         | 208 ++++++++++++++++++++++---
 drivers/pinctrl/renesas/pfc-r8a73a4.c  |   4 +-
 drivers/pinctrl/renesas/pfc-r8a7740.c  |   6 +-
 drivers/pinctrl/renesas/pfc-r8a77470.c |   3 +-
 drivers/pinctrl/renesas/pfc-r8a7790.c  |   2 +-
 drivers/pinctrl/renesas/pfc-r8a7791.c  |   2 +-
 drivers/pinctrl/renesas/pfc-r8a7794.c  |   2 +-
 drivers/pinctrl/renesas/pfc-r8a77950.c |   3 +-
 drivers/pinctrl/renesas/pfc-r8a77951.c |   3 +-
 drivers/pinctrl/renesas/pfc-r8a7796.c  |   3 +-
 drivers/pinctrl/renesas/pfc-r8a77965.c |   3 +-
 drivers/pinctrl/renesas/pfc-r8a77970.c |   3 +-
 drivers/pinctrl/renesas/pfc-r8a77980.c |   3 +-
 drivers/pinctrl/renesas/pfc-r8a77990.c |   3 +-
 drivers/pinctrl/renesas/pfc-r8a77995.c |   4 +-
 drivers/pinctrl/renesas/pfc-r8a779a0.c |   3 +-
 drivers/pinctrl/renesas/pfc-sh73a0.c   |   4 +-
 drivers/pinctrl/renesas/pinctrl.c      |  24 +--
 drivers/pinctrl/renesas/sh_pfc.h       |   6 +-
 19 files changed, 227 insertions(+), 62 deletions(-)
Signature · 12 lines
2.25.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds