Skip to content

scsi: lpfc: Cleanup some bitmap handling.

Christophe JAILLET kernel-janitors linux-scsi lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2scsi: lpfc: Use bitmap_zalloc() when applicabledrivers/scsi/lpfc/lpfc_init.c+4 -60 replies
2/2scsi: lpfc: Make sure to completely clear some bitmapsdrivers/scsi/lpfc/lpfc_hbadisc.c drivers/scsi/lpfc/lpfc_sli.c+5 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] scsi: lpfc: Cleanup some bitmap handling.

The 1st patch of this serie uses bitmap_zalloc() to simplify code. The 2nd patch makes sure that the whole bitmap is cleared, should it need more than 1 long.

However, this 'fcf_rr_bmask' is small (LPFC_SLI4_FCF_TBL_INDX_MAX = 32 bits), so another option could be to use DECLARE_BITMAP instead of dynamic allocation.

This would simplify code (no more allocation and associated error handling) and be slighly more efficient (1 less indirection when accessing the bitmap). In the case the 2nd patch could also be removed (using bitmap_zero() would still be cleaner (IMHO), but the actual memset+sizeof would work as expected)

Let me know if I should send a v2 with this other approach.

Christophe JAILLET (2):
scsi: lpfc: Use bitmap_zalloc() when applicable
scsi: lpfc: Make sure to completely clear some bitmaps

 drivers/scsi/lpfc/lpfc_hbadisc.c |  7 ++++---
 drivers/scsi/lpfc/lpfc_init.c    | 10 ++++------
 drivers/scsi/lpfc/lpfc_sli.c     |  3 +--
 3 files changed, 9 insertions(+), 11 deletions(-)
Signature · 1 line
2.32.0