Skip to content

ext4/jbd2: inline_data fixes and minor cleanups

Ritesh Harjani linux-ext4 linux-fsdevel lkml 2 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 1 replyApplied
  2. v16 patches 10 repliesSuperseded

Changes in v2 from the cover letter

========
1. Added Jan's Reviewed-by tag & addressed one of his comment on no need to make jbd2_journal_wait_updates() function inline.
2. Dropped patch-6 as described above.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/5ext4: Fix error handling in ext4_restore_inline_data()fs/ext4/inline.c+9 -10 replies
2/5ext4: Remove redundant max inline_size check in ext4_da_write_inline_data_begin()fs/ext4/inline.c+4 -90 replies
3/5ext4: Fix error handling in ext4_fc_record_modified_inode()fs/ext4/fast_commit.c+29 -350 replies
4/5jbd2: Cleanup unused functions declarations from jbd2.hinclude/linux/jbd2.h+0 -70 replies
5/5jbd2: Refactor wait logic for transaction updates into a common functionfs/jbd2/commit.c fs/jbd2/transaction.c include/linux/jbd2.h+38 -380 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchJan Kara
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCHv2 0/5] ext4/jbd2: inline_data fixes and minor cleanups

Hello,

Please find v2 of the inline_data fixes and some minor cleanups found during code review.

I have dropped patch-6 in v2 which was removing use of t_handle_lock (spinlock) from within jbd2_journal_wait_updates(). Based on Jan comments, I feel we can push that as killing of t_handle_lock into a separate series (which will be on top of this).

v1 -> v2
========
1. Added Jan's Reviewed-by tag & addressed one of his comment on no need to make jbd2_journal_wait_updates() function inline.
2. Dropped patch-6 as described above.

Description
============
Patch[1]: fixes BUG_ON with inline_data which was reported [1] with generic/475.

Patch[2]: is mostly cleanup found during code review of inline_data code.

Patch[3]: is a possible memory corruption fix in case of krealloc failure.

Patch[4-5]: Cleanups.

[v1]: https://lore.kernel.org/linux-ext4/[email protected]/T/

Ritesh Harjani (5):
ext4: Fix error handling in ext4_restore_inline_data()
ext4: Remove redundant max inline_size check in ext4_da_write_inline_data_begin()
ext4: Fix error handling in ext4_fc_record_modified_inode()
jbd2: Cleanup unused functions declarations from jbd2.h
jbd2: Refactor wait logic for transaction updates into a common function

 fs/ext4/fast_commit.c | 64 ++++++++++++++++++++-----------------------
 fs/ext4/inline.c      | 23 +++++++++-------
 fs/jbd2/commit.c      | 19 ++-----------
 fs/jbd2/transaction.c | 53 +++++++++++++++++++++--------------
 include/linux/jbd2.h  | 11 ++------
 5 files changed, 80 insertions(+), 90 deletions(-)

--
2.31.1