Skip to content

mkimage: allow to specify signing algorithm

Jan Kiszka u-boot 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3image-fit: Make string of algo parameter constantboot/image-fit-sig.c boot/image-fit.c include/image.h +1 more+8 -82 replies
2/3mkimage: Drop unused OPT_STRING constanttools/mkimage.c+0 -12 replies
3/3mkimage: Allow to specify the signature algorithm on the command linedoc/mkimage.1 include/image.h tools/fit_image.c +3 more+42 -232 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchSimon Glass
1/3R-b
2/3R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [resent][PATCH 0/3] mkimage: allow to specify signing algorithm

[resent as requested by Simon]

Another step to decouple the FIT image specification from the actual
signing: With these changes, the signature nodes can leave out an algo property, mkimage will initialize that as well while signing. This way, in-tree FIT source files can be prepared for gaining signatures without defining the key type or size upfront, forcing users to patch the code to change that.

Patch 1 is preparatory for this, patch 2 a drive-by cleanup.

A better solution would actually be if the algorithm was derived from the provided key. But the underlying crypto layer seems to be rather unprepared for that.

Jan

Jan Kiszka (3):
image-fit: Make string of algo parameter constant
mkimage: Drop unused OPT_STRING constant
mkimage: Allow to specify the signature algorithm on the command line

 boot/image-fit-sig.c |  2 +-
 boot/image-fit.c     |  8 +++----
 doc/mkimage.1        |  5 +++++
 include/image.h      |  5 +++--
 tools/fit_image.c    |  3 ++-
 tools/image-host.c   | 50 +++++++++++++++++++++++++-------------------
 tools/imagetool.h    |  1 +
 tools/mkimage.c      |  6 ++++--
 8 files changed, 49 insertions(+), 31 deletions(-)
Signature · 1 line
2.31.1