Skip to content

Misc OHCI clean ups

BALATON Zoltan qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 4 repliesIn review
  2. v15 patches 7 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5usb/ohci: Move trace point and log ep number to help debugginghw/usb/hcd-ohci.c hw/usb/trace-events+8 -80 replies
2/5usb/ohci: Move cancelling async packet to ohci_stop_endpoints()hw/usb/hcd-ohci.c+4 -80 replies
3/5usb/ohci: Move USBPortOps related functions togetherhw/usb/hcd-ohci.c+101 -1040 replies
4/5usb/ohci: Merge ohci_async_cancel_device() into ohci_child_detach()hw/usb/hcd-ohci.c+4 -90 replies
5/5usb/ohci: Don't use packet from OHCIState for isochronous transfershw/usb/hcd-ohci.c+38 -330 replies

Reviews trailers per patch

2 of 5 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-Daudé
1/5
2/5
3/5R-b
4/5R-b
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] Misc OHCI clean ups

v2 - Fixed checkpatch errors

Hello,

I have these patches from last October when we've looked at what causes problems with mac99 and USB. We've found the main problem is likely not allowing pending packets per endpoint which we did not fix but these patches came out of debugging that and trying to improve the device model so eventually the real problem could be fixed more easily. So these are just clean ups and fixing one potential issue with isochronous transfers breaking pending async packet but it does not solve all problems OHCI currently has. I'm sending it anyway as I don't plan to work further on this so this series could be taken as is for now.

Regards,

BALATON Zoltan (5):
usb/ohci: Move trace point and log ep number to help debugging usb/ohci: Move cancelling async packet to ohci_stop_endpoints() usb/ohci: Move USBPortOps related functions together usb/ohci: Merge ohci_async_cancel_device() into ohci_child_detach() usb/ohci: Don't use packet from OHCIState for isochronous transfers

 hw/usb/hcd-ohci.c   | 297 +++++++++++++++++++++-----------------------
 hw/usb/trace-events |   2 +-
 2 files changed, 146 insertions(+), 153 deletions(-)
Signature · 1 line
2.30.2