Skip to content

Refactor the PRCI driver to reduce the complexity

Zong Li linux-clk linux-devicetree linux-riscv lkml 2 versions – Applied

Status from this message: Applied to clk-next

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 8 repliesApplied
  2. v14 patches 6 repliesSuperseded

Changes in v2 from the cover letter

- Rebase on v5.17-rc6
- Add a temporary patch for avoiding breaking git bisect

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/5clk: sifive: duplicate the macro definitions for the time beingdrivers/clk/sifive/fu540-prci.c drivers/clk/sifive/fu740-prci.c+15 -21 reply
2/5dt-bindings: change the macro name of prci in header files and exampleDocumentation/devicetree/bindings/gpio/sifive,gpio.yaml Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml Documentation/devicetree/bindings/serial/sifive-serial.yaml +2 more+16 -161 reply
3/5riscv: dts: Change the macro name of prci in each device nodearch/riscv/boot/dts/sifive/fu540-c000.dtsi arch/riscv/boot/dts/sifive/fu740-c000.dtsi+24 -244 replies
4/5clk: sifive: Add SoCs prefix in each SoCs-dependent datadrivers/clk/sifive/fu540-prci.c drivers/clk/sifive/fu740-prci.c+35 -501 reply
5/5clk: sifive: Move all stuff into SoCs header files from C filesdrivers/clk/sifive/Makefile drivers/clk/sifive/fu540-prci.c drivers/clk/sifive/fu540-prci.h +3 more+214 -2351 reply

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchRob HerringPalmer DabbeltLee Jones
1/5
2/5A-b A-b
3/5A-b
4/5A-b
5/5A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/5] Refactor the PRCI driver to reduce the complexity

This patch set tries to improve the PRCI driver to reduce the complexity, we remove the SoCs C files by putting putting all stuff in each SoCs header file, and include these SoCs-specific header files in core of PRCI. It can also avoid the W=1 kernel build warnings about variable defined but not used [-Wunused-const-variable=], like 'commit 487dc7bb6a0c ("clk: sifive:fu540-prci: Declare static const variable 'prci_clk_fu540' where it's used")' does.

This patch set also contains the dt-bindings and dts change, because we change the macro name for fu540 and fu740 by adding the prefix respectively.

Thanks all for your review and suggestions.

Changed in v2:
- Rebase on v5.17-rc6
- Add a temporary patch for avoiding breaking git bisect

Zong Li (5):
clk: sifive: duplicate the macro definitions for the time being
dt-bindings: change the macro name of prci in header files and example
riscv: dts: Change the macro name of prci in each device node
clk: sifive: Add SoCs prefix in each SoCs-dependent data
clk: sifive: Move all stuff into SoCs header files from C files

 .../devicetree/bindings/gpio/sifive,gpio.yaml |   2 +-
 .../bindings/pci/sifive,fu740-pcie.yaml       |   2 +-
 .../bindings/serial/sifive-serial.yaml        |   2 +-
 arch/riscv/boot/dts/sifive/fu540-c000.dtsi    |  22 +--
 arch/riscv/boot/dts/sifive/fu740-c000.dtsi    |  26 ++--
 drivers/clk/sifive/Makefile                   |   2 +-
 drivers/clk/sifive/fu540-prci.c               |  89 ------------
 drivers/clk/sifive/fu540-prci.h               |  91 +++++++++++-
 drivers/clk/sifive/fu740-prci.c               | 134 ------------------
 drivers/clk/sifive/fu740-prci.h               | 130 ++++++++++++++++-
 drivers/clk/sifive/sifive-prci.c              |   5 -
 include/dt-bindings/clock/sifive-fu540-prci.h |   8 +-
 include/dt-bindings/clock/sifive-fu740-prci.h |  18 +--
 13 files changed, 254 insertions(+), 277 deletions(-)
 delete mode 100644 drivers/clk/sifive/fu540-prci.c
 delete mode 100644 drivers/clk/sifive/fu740-prci.c
Signature · 1 line
2.31.1