Skip to content

tracing: Misc bugfixes

Tom Zanussi lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 2 repliesIn review
  2. v17 patches 2 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2tracing: Remove size restriction on hist trigger cmd error loggingkernel/trace/trace_events_hist.c+23 -70 replies
2/2tracing: Remove size restriction on synthetic event cmd error loggingkernel/trace/trace_events_synth.c+14 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] tracing: Misc bugfixes

There were 2 patches in v1 that were flagged by the 0day robot for strncpy off-by-1 warnings:

tracing: Remove size restriction on hist trigger cmd error logging
tracing: Remove size restriction on synthetic event cmd error logging

warning: 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation]

This v2 patchset consists of just those two patches with the fix for those warnings.

Tom

v1 text below

Hi Steve,

This is an assorted bunch of bugfixes addressing a bugzilla bug, smatch warnings, and related things I found while fixing those. In particular, when looking at the bugzilla bug,
https://bugzilla.kernel.org/show_bug.cgi?id=215513, I noticed that the err_log output looked truncated and looking further into it found that it was, because the hist trigger command was very long, exceeding the 256 character limit.

Obviously that's too short, and the final 3 patches remove that limitation.

Tom

The following changes since commit ca965f23256b350ebd94b3dc1a319f28e8267f5f:

tracing: Remove size restriction on tracing_log_err cmd strings (2022-01-27 15:38:28 -0600)

are available in the Git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/zanussi/linux-trace.git ftrace/misc-bugfixes-v2

Tom Zanussi (2):
tracing: Remove size restriction on hist trigger cmd error logging
tracing: Remove size restriction on synthetic event cmd error logging

 kernel/trace/trace_events_hist.c  | 30 +++++++++++++++++++++++-------
 kernel/trace/trace_events_synth.c | 17 ++++++++++++++---
 2 files changed, 37 insertions(+), 10 deletions(-)
Signature · 1 line
2.17.1