Skip to content

selftests/sgx: Early enclave loading error path fixes

Reinette Chatre linux-kselftest linux-sgx lkml 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 0 repliesNew
  2. v24 patches 13 repliesSuperseded
  3. v14 patches 13 repliesSuperseded

Changes in v3 from the cover letter

- V2: https://lore.kernel.org/linux-sgx/[email protected]/
- Added Acked-by from Shuah to all patches in series.
- Shuah is ok with these entering the kernel via tip.git:
https://lore.kernel.org/linux-sgx/[email protected]/
- Include [email protected] and more x86 maintainers since goal is for inclusion into tip.git.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4selftests/sgx: Fix NULL-pointer-dereference upon early test failuretools/testing/selftests/sgx/load.c+5 -40 replies
2/4selftests/sgx: Do not attempt enclave build without valid enclavetools/testing/selftests/sgx/main.c+1 -00 replies
3/4selftests/sgx: Ensure enclave data available during debug printtools/testing/selftests/sgx/main.c+2 -20 replies
4/4selftests/sgx: Remove extra newlines in test outputtools/testing/selftests/sgx/main.c+2 -20 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchShuah KhanDave Hansen
1/4A-b
2/4A-b A-b
3/4A-b
4/4A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH V3 0/4] selftests/sgx: Early enclave loading error path fixes

Changes since V2:
- V2: https://lore.kernel.org/linux-sgx/[email protected]/
- Added Acked-by from Shuah to all patches in series.
- Shuah is ok with these entering the kernel via tip.git:
https://lore.kernel.org/linux-sgx/[email protected]/
- Include [email protected] and more x86 maintainers since goal is for inclusion into tip.git.

Changes since V1:
- V1: https://lore.kernel.org/linux-sgx/[email protected]/
- All changes impact the commit messages only, no changes to code.
- Rewrite commit message of 1/4 (Dave).
- Detail in 2/4 commit log what callers will see with this change (Dave).
- Add Acked-by from Dave to 2/4 and 4/4.

Hi Everybody,

Please find included a few fixes that address problems encountered after venturing into the enclave loading error handling code of the SGX selftests.

Reinette

Reinette Chatre (4):
selftests/sgx: Fix NULL-pointer-dereference upon early test failure selftests/sgx: Do not attempt enclave build without valid enclave selftests/sgx: Ensure enclave data available during debug print selftests/sgx: Remove extra newlines in test output

 tools/testing/selftests/sgx/load.c | 9 +++++----
 tools/testing/selftests/sgx/main.c | 9 +++++----
 2 files changed, 10 insertions(+), 8 deletions(-)
Signature · 1 line
2.25.1