Skip to content

fix memory leak in get_task_name()

Andrea Claudi netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 1 replyIn review
  2. v22 patches 9 repliesSuperseded
  3. v13 patches 3 repliesSuperseded

Changes in v3 from the cover letter

- Use a better API for get_task_name(), passing to it a buffer and its lenght just like get_command_name().

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2lib/fs: fix memory leak in get_task_name()include/utils.h ip/iptuntap.c lib/fs.c +8 more+59 -401 reply
2/2rdma: make RES_PID and RES_KERN_NAME alternative to each otherrdma/res-cmid.c rdma/res-cq.c rdma/res-ctx.c +5 more+34 -390 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH iproute2 v3 0/2] fix memory leak in get_task_name()

This series fixes some memory leaks related to the usage of the get_task_name() function from lib/fs.c.

Patch 2/2 addresses a coverity warning related to this memory leak, making the code a bit more readable by humans and coverity.

Changelog:
----------
v2 -> v3
- Use a better API for get_task_name(), passing to it a buffer and its lenght just like get_command_name().

v1 -> v2
- on Stephen's suggestion, drop asprintf() and use a local var for path; additionally drop %m from fscanf to not allocate memory, and resort to a param to return task name to the caller.
- patch 2/3 of the original series is no more needed.

Andrea Claudi (2):
lib/fs: fix memory leak in get_task_name()
rdma: make RES_PID and RES_KERN_NAME alternative to each other

 include/utils.h |  2 +-
 ip/iptuntap.c   | 17 ++++++++++-------
 lib/fs.c        | 23 +++++++++++++----------
 rdma/res-cmid.c | 18 +++++++++---------
 rdma/res-cq.c   | 17 +++++++++--------
 rdma/res-ctx.c  | 16 ++++++++--------
 rdma/res-mr.c   | 15 ++++++++-------
 rdma/res-pd.c   | 17 +++++++++--------
 rdma/res-qp.c   | 16 ++++++++--------
 rdma/res-srq.c  | 17 +++++++++--------
 rdma/stat.c     | 14 +++++++++-----
 11 files changed, 93 insertions(+), 79 deletions(-)
Signature · 1 line
2.35.1