Skip to content

Deprecate interrupt-map for realtek-rtl IRQ driver

Sander Vanheule linux-devicetree lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest3 patches 2 repliesIn review
  2. v54 patches 2 repliesSuperseded
  3. v43 patches 4 repliesSuperseded

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3irqchip/realtek-rtl: use irq_domain_add_linear()drivers/irqchip/irq-realtek-rtl.c+1 -20 replies
2/3dt-bindings: interrupt-controller: realtek,rtl-intc: require parentsDocumentation/devicetree/bindings/interrupt-controller/realtek,rtl-intc.yaml+45 -152 replies
3/3irqchip/realtek-rtl: use parent interruptsdrivers/irqchip/irq-realtek-rtl.c+61 -720 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchRob Herring
1/3
2/3R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/3] Deprecate interrupt-map for realtek-rtl IRQ driver

The original implementation for this interrupt controller/router used an interrupt-map parser to determine which parent interrupts were present. However, this controller is not transparent, so a list of parent interrupts seems more appropriate, while also getting rid of the assumed routing to parent interrupts.

Changes since v5:

- Allow interrupt-map for new compatibles, but mark as deprecated
- Change back to single-cell interrupt specifiers
- Drop patch adding a domain for every output line

Changes since v4:

- Add Rob's Reviewed-by
- Use irq_domain_add_linear instead of irq_domain_add_simple
- Drop 'inline' specifiers from static functions
- Drop WARN in intc_select() to only warn once for old bindings

Changes since v3:

- Patches with fixes were merged, so these are no longer included.
- Update the devicetree changes to more clearly indicate the controller is not transparent.

Changes since v2 (RFC):

- Define new, two-part compatibles for devicetree bindings. The existing format is kept for the old one-part compatible, but deprecated. New compatibles will require a different way of specifying parent interrupts and interrupt routing.
- Add change to handle all pending SoC interrupts in one go.

Changes since v1 (RFC):

- Split some of the changes to limit the patch scope to one issue.
- Dropped some small (spurious or unneeded) changes
- Instead of dropping/replacing interrupt-map, the last patches now provide an implementation that amends the current situtation.

Sander Vanheule (3):
irqchip/realtek-rtl: use irq_domain_add_linear
dt-bindings: interrupt-controller: realtek,rtl-intc: require parents irqchip/realtek-rtl: use parent interrupts

 .../realtek,rtl-intc.yaml                     |  60 ++++++--
 drivers/irqchip/irq-realtek-rtl.c             | 134 ++++++++----------
 2 files changed, 106 insertions(+), 88 deletions(-)
Signature · 1 line
2.37.3