Skip to content

midx: prevent writing a bitmap with zero objects

Taylor Blau git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1midx: prevent writing a .bitmap without any objectsmidx.c t/t5326-multi-pack-bitmaps.sh+31 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] midx: prevent writing a bitmap with zero objects

Here is a small patch I wrote after getting an alert that we tried to call pack_pos_to_midx(..., 0) on a MIDX that contained zero objects.

The patch causes us to no longer write a bitmap for such a MIDX. More detailed notes are within, and this is based on tb/midx-bitmap-corruption-fix. (The only reason is that both this topic and that one add a new test to t5326, so merging this one after that avoids a textual conflict).

Thanks in advance for your review.

Taylor Blau (1):
midx: prevent writing a .bitmap without any objects

 midx.c                        |  9 +++++++++
 t/t5326-multi-pack-bitmaps.sh | 22 ++++++++++++++++++++++
 2 files changed, 31 insertions(+)
Signature · 1 line
2.35.1.73.gccc5557600