Skip to content

MP_FAIL echo and retrans

Geliang Tang mptcp 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest6 patches 4 repliesIn review
  2. v44 patches 2 repliesSuperseded
  3. v33 patches 2 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v2 posting 2/23 patches3 repliesSuperseded
v2 RFC posting 1/26 patches3 repliesSuperseded
v1 RFC6 patches1 replySuperseded

Changes in v5 from the cover letter

- re-check for TCP_CLOSE.
- add a new helper mptcp_check_mp_fail_response().
- add two timers cleanup patches.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6mptcp: use mptcp_stop_timernet/mptcp/protocol.c+2 -20 replies
2/6mptcp: add data lock for sk timersnet/mptcp/protocol.c+12 -00 replies
3/6mptcp: add MP_FAIL response supportnet/mptcp/pm.c net/mptcp/protocol.h net/mptcp/subflow.c+12 -10 replies
4/6mptcp: reset subflow when MP_FAIL doesn't respondnet/mptcp/pm.c net/mptcp/protocol.c net/mptcp/protocol.h +1 more+68 -00 replies
5/6selftests: mptcp: check MP_FAIL response mibstools/testing/selftests/net/mptcp/mptcp_join.sh+35 -30 replies
6/6selftests: mptcp: print extra msg in chk_csum_nrtools/testing/selftests/net/mptcp/mptcp_join.sh+10 -11 reply

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMat Martineau
SeriesR-b
1/6
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH mptcp-next v5 0/6] MP_FAIL echo and retrans

v5:
- re-check for TCP_CLOSE.
- add a new helper mptcp_check_mp_fail_response().
- add two timers cleanup patches.

v4:
- start and stop sk_timer instead of setting and clearing msk->flags.
- add a new patch.

v3:
- use msk->sk_timer and a msk->flags bit.
- use READ_ONCE/WRITE_ONCE for subflow->mp_fail_response_expect.
- update selftest.

v2:
- don't clear mp_fail_response_expect flag.
- add a helper mp_fail_response_expect_subflow to get the subflow, instead of using msk->first.
- add locks as Mat suggested.
- add a selftest.

Geliang Tang (6):
mptcp: use mptcp_stop_timer
mptcp: add data lock for sk timers
mptcp: add MP_FAIL response support
mptcp: reset subflow when MP_FAIL doesn't respond
selftests: mptcp: check MP_FAIL response mibs
selftests: mptcp: print extra msg in chk_csum_nr

 net/mptcp/pm.c                                | 18 +++++-
 net/mptcp/protocol.c                          | 64 ++++++++++++++++++-
 net/mptcp/protocol.h                          |  2 +
 net/mptcp/subflow.c                           | 13 ++++
 .../testing/selftests/net/mptcp/mptcp_join.sh | 49 ++++++++++++--
 5 files changed, 139 insertions(+), 7 deletions(-)
Signature · 1 line
2.34.1