Skip to content

scsi: aacraid: Replace one-element arrays with flexible-array members

Gustavo A. R. Silva linux-hardening linux-scsi lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8scsi: aacraid: Replace one-element array with flexible-array memberdrivers/scsi/aacraid/aachba.c drivers/scsi/aacraid/aacraid.h+3 -40 replies
2/8scsi: aacraid: Replace one-element array with flexible-array member in struct sgmapdrivers/scsi/aacraid/aachba.c drivers/scsi/aacraid/aacraid.h drivers/scsi/aacraid/commctrl.c +1 more+16 -300 replies
3/8scsi: aacraid: Replace one-element array with flexible-array member in struct user_sgmapdrivers/scsi/aacraid/aacraid.h drivers/scsi/aacraid/commctrl.c+2 -20 replies
4/8scsi: aacraid: Replace one-element array with flexible-array member in struct sgmap64drivers/scsi/aacraid/aachba.c drivers/scsi/aacraid/aacraid.h+6 -110 replies
5/8scsi: aacraid: Replace one-element array with flexible-array member in struct user_sgmap64drivers/scsi/aacraid/aacraid.h+1 -10 replies
6/8scsi: aacraid: Replace one-element array with flexible-array member in struct sgmaprawdrivers/scsi/aacraid/aachba.c drivers/scsi/aacraid/aacraid.h+7 -130 replies
7/8scsi: aacraid: Replace one-element array with flexible-array member in struct user_sgmaprawdrivers/scsi/aacraid/aacraid.h+1 -10 replies
8/8scsi: aacraid: Replace one-element array with flexible-array member in struct aac_aifcmddrivers/scsi/aacraid/aacraid.h+1 -11 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/8] scsi: aacraid: Replace one-element arrays with flexible-array members

This series aims to replace one-element arrays with flexible-array members in multiple structures in drivers/scsi/aacraid/aacraid.h.

There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use “flexible array members”[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2].

This helps with the ongoing efforts to globally enable -Warray-bounds and get us closer to being able to tighten the FORTIFY_SOURCE routines on memcpy().

These issues were found with the help of Coccinelle and audited and fixed, manually.

[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays

Gustavo A. R. Silva (8):
scsi: aacraid: Replace one-element array with flexible-array member
scsi: aacraid: Replace one-element array with flexible-array member in
struct sgmap
scsi: aacraid: Replace one-element array with flexible-array member in
struct user_sgmap
scsi: aacraid: Replace one-element array with flexible-array member in
struct sgmap64
scsi: aacraid: Replace one-element array with flexible-array member in
struct user_sgmap64
scsi: aacraid: Replace one-element array with flexible-array member in
struct sgmapraw
scsi: aacraid: Replace one-element array with flexible-array member in
struct user_sgmapraw
scsi: aacraid: Replace one-element array with flexible-array member in
struct aac_aifcmd

 drivers/scsi/aacraid/aachba.c   | 76 +++++++++++----------------------
 drivers/scsi/aacraid/aacraid.h  | 16 +++----
 drivers/scsi/aacraid/commctrl.c |  5 +--
 drivers/scsi/aacraid/comminit.c |  3 +-
 4 files changed, 37 insertions(+), 63 deletions(-)
Signature · 1 line
2.27.0