btrfs: scrub: big renaming to address the page and sector difference
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest3 patches 2 repliesIn review
- v23 patches 4 repliesSuperseded
- v13 patches 3 repliesSuperseded
Changes in v3 from the cover letter
- Get rid of the name "ssector", using "sector" directly. Previously we use names like "spage" to avoid confusion between MM layer page, and scrub page.
But now since we rename it to scrub sector, and there is no naming conflicts, we are safe to use "sector" directly, without the eye hurting "ss".
- Use names like "sectors" to replace "pagev" Which is more close to our latest naming schema.
- Update involved comments to use latest style
- Use bitshift to convert from sectors to bytes
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | btrfs: scrub: rename members related to scrub_block::pagevfs/ | +110 | 1 reply | |
| 2/3 | btrfs: scrub: rename scrub_page to scrub_sectorfs/ | +232 | 0 replies | |
| 3/3 | btrfs: scrub: rename scrub_bio::pagev[] and related membersfs/ | +38 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.
Cover letter [PATCH v3 0/3] btrfs: scrub: big renaming to address the page and sector difference
[CHANGELOG]
v2:
- Rebased to misc-next directly, before scrub entrance refactor As this patchset is safer than entrance refactor.
Minor conflicts due to scrub_remap() renaming.
v3:
- Get rid of the name "ssector", using "sector" directly. Previously we use names like "spage" to avoid confusion between MM layer page, and scrub page.
But now since we rename it to scrub sector, and there is no naming conflicts, we are safe to use "sector" directly, without the eye hurting "ss".
- Use names like "sectors" to replace "pagev" Which is more close to our latest naming schema.
- Update involved comments to use latest style
- Use bitshift to convert from sectors to bytes
This patchset can be cherry-picked from my github repo:
https://github.com/adam900710/linux/tree/refactor_scrub
They are the first 3 patches after misc-next.
From the ancient day, btrfs doesn't support sectorsize < PAGE_SIZE, thus a lot of the old code consider one page == one sector, not only the behavior, but also the naming.
This is no longer true after v5.16 since we have subpage support.
One of the worst location is scrub, we have tons of things named like scrub_page, scrub_block::pagev, scrub_bio::pagev.
Even scrub for subpage is supported, the naming is not touched yet.
This patchset will first do the rename, providing the basis for later scrub enhancement for subpage.
This patchset should not bring any behavior change.
Qu Wenruo (3):
btrfs: scrub: rename members related to scrub_block::pagev
btrfs: scrub: rename scrub_page to scrub_sector
btrfs: scrub: rename scrub_bio::pagev[] and related members
fs/btrfs/scrub.c | 693 +++++++++++++++++++++++------------------------ 1 file changed, 346 insertions(+), 347 deletions(-)
Signature · 1 line
2.35.1