Skip to content

btrfs-progs: cleanup btrfs_item* accessors

Josef Bacik linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13btrfs-progs: turn on more compiler warnings and use -WallMakefile+3 -03 replies
2/13btrfs-progs: store LEAF_DATA_SIZE in the mkfs_configmkfs/common.c mkfs/common.h mkfs/main.c+6 -50 replies
3/13btrfs-progs: store BTRFS_LEAF_DATA_SIZE in the fs_infokernel-shared/ctree.h kernel-shared/disk-io.c+3 -20 replies
4/13btrfs-progs: convert: use cfg->leaf_data_sizeconvert/common.c convert/main.c+5 -42 replies
5/13btrfs-progs: reduce usage of __BTRFS_LEAF_DATA_SIZEkernel-shared/ctree.c kernel-shared/ctree.h kernel-shared/print-tree.c +1 more+8 -60 replies
6/13btrfs-progs: btrfs_item_size_nr/btrfs_item_offset_nr everywherecheck/main.c image/main.c kernel-shared/backref.c +4 more+24 -302 replies
7/13btrfs-progs: add btrfs_set_item_*_nr() helpersbtrfs-corrupt-block.c check/main.c convert/common.c +4 more+74 -1020 replies
8/13btrfs-progs: change btrfs_file_extent_inline_item_len to take a slotcheck/main.c check/mode-lowmem.c cmds/inspect-tree-stats.c +4 more+14 -290 replies
9/13btrfs-progs: rename btrfs_item_end_nr to btrfs_item_endcheck/main.c kernel-shared/ctree.c kernel-shared/ctree.h+21 -270 replies
10/13btrfs-progs: remove the _nr from the item helpersbtrfs-corrupt-block.c check/main.c check/mode-common.c +19 more+206 -2140 replies
11/13btrfs-progs: replace btrfs_item_nr_offset(0)kernel-shared/ctree.c+5 -51 reply
12/13btrfs-progs: rework the btrfs_node accessors to match the item accessorskernel-shared/ctree.h+19 -300 replies
13/13btrfs-progs: make all of the item/key_ptr offset helpers take an ebcheck/main.c image/main.c kernel-shared/ctree.c +1 more+54 -530 replies

Reviews trailers per patch

None of the 13 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchNikolay Borisov
SeriesR-b
1/13
2/13
3/13
4/13
5/13
6/13
7/13
8/13
9/13
10/13
11/13
12/13
13/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/13] btrfs-progs: cleanup btrfs_item* accessors

Hello,

This is prep work for me adjusting the size of the btrfs_header. This is a mirror of the work that was already merged into the kernel. The only extra work that I've done here is add some compiler switches that I used to help me catch all the different users of the helpers to make sure I didn't make any mistakes. Thanks,

Josef

Josef Bacik (13):
btrfs-progs: turn on more compiler warnings and use -Wall
btrfs-progs: store LEAF_DATA_SIZE in the mkfs_config
btrfs-progs: store BTRFS_LEAF_DATA_SIZE in the fs_info
btrfs-progs: convert: use cfg->leaf_data_size
btrfs-progs: reduce usage of __BTRFS_LEAF_DATA_SIZE
btrfs-progs: btrfs_item_size_nr/btrfs_item_offset_nr everywhere
btrfs-progs: add btrfs_set_item_*_nr() helpers
btrfs-progs: change btrfs_file_extent_inline_item_len to take a slot
btrfs-progs: rename btrfs_item_end_nr to btrfs_item_end
btrfs-progs: remove the _nr from the item helpers
btrfs-progs: replace btrfs_item_nr_offset(0)
btrfs-progs: rework the btrfs_node accessors to match the item
accessors
btrfs-progs: make all of the item/key_ptr offset helpers take an eb

 Makefile                    |   3 +
 btrfs-corrupt-block.c       |  17 ++-
 check/main.c                |  90 +++++++--------
 check/mode-common.c         |  12 +-
 check/mode-lowmem.c         |  37 +++---
 check/qgroup-verify.c       |   2 +-
 cmds/inspect-tree-stats.c   |   3 +-
 cmds/rescue-chunk-recover.c |   4 +-
 cmds/restore.c              |   7 +-
 convert/common.c            |  33 +++---
 convert/main.c              |   1 +
 image/main.c                |  31 +++--
 image/sanitize.c            |   4 +-
 kernel-shared/backref.c     |  10 +-
 kernel-shared/ctree.c       | 219 ++++++++++++++++--------------------
 kernel-shared/ctree.h       | 110 ++++++++----------
 kernel-shared/dir-item.c    |  10 +-
 kernel-shared/disk-io.c     |   1 +
 kernel-shared/extent-tree.c |  12 +-
 kernel-shared/file-item.c   |  12 +-
 kernel-shared/inode-item.c  |  14 +--
 kernel-shared/print-tree.c  |  29 +++--
 kernel-shared/root-tree.c   |   2 +-
 kernel-shared/uuid-tree.c   |   4 +-
 kernel-shared/volumes.c     |  10 +-
 mkfs/common.c               |  52 ++++-----
 mkfs/common.h               |   1 +
 mkfs/main.c                 |   1 +
 28 files changed, 333 insertions(+), 398 deletions(-)
Signature · 1 line
2.26.3