Skip to content

btrfs: scrub: changes to reduce memory usage for both regular and subpage sectorsize.

Qu Wenruo linux-btrfs 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 0 repliesNew
  2. v25 patches 3 repliesSuperseded
  3. v10 of 5 patches 4 repliesSuperseded

Changes in v3 from the cover letter

- Move various members from scrub_sector to scrub_block
This reduce memory usage as now those members are per-block instead of per-sector.

- Enlarge blocksize for data extent scrub
This will greatly benefit from above change.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7btrfs: scrub: use pointer array to replace @sblocks_for_recheckfs/btrfs/scrub.c+56 -460 replies
2/7btrfs: extract the initialization of scrub_block into a helper functionfs/btrfs/scrub.c+24 -250 replies
3/7btrfs: extract the allocation and initialization of scrub_sector into a helperfs/btrfs/scrub.c+31 -320 replies
4/7btrfs: scrub: introduce scrub_block::pages for more efficient memory usage for subpagefs/btrfs/scrub.c+115 -220 replies
5/7btrfs: scrub: remove scrub_sector::page and use scrub_block::pages insteadfs/btrfs/scrub.c+65 -320 replies
6/7btrfs: scrub: move logical/physical/dev/mirror_num from scrub_sector to scrub_blockfs/btrfs/scrub.c+92 -720 replies
7/7btrfs: use larger blocksize for data extent scrubfs/btrfs/scrub.c+7 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/7] btrfs: scrub: changes to reduce memory usage for both regular and subpage sectorsize.

[Changelog]
v3:
- Move various members from scrub_sector to scrub_block
This reduce memory usage as now those members are per-block instead of per-sector.

- Enlarge blocksize for data extent scrub
This will greatly benefit from above change.

v2:
- Rebased to latest misc-next
The conflicts are mostly from the member renaming. Has re-ran the tests on both aarch64 64K page size, and x86_64. For both scrub and replace groups.

Although btrfs scrub works for subpage from day one, it has a small pitfall:

Scrub will always allocate a full page for each sector.

This causes increased memory usage, although not a big deal, it's still not ideal.

The patchset will change the behavior by integrating all pages into scrub_block::pages[], instead of using scrub_sector::page.

Now scrub_sector will no longer hold a page pointer, but uses its logical bytenr to caculate which page and page range it should use.

And since we're here, also move several members from scrub_sector to scrub_block, and further enlarge the blocksize for data extent scrub.

[MEMORY USAGE CHANGE]

For 4K page systems
The memory usage for scrubbing a 16KiB metadata is:

Old: 240 + 4 * 128 = 752
New: 408 + 4 * 96 = 792
Diff: +5.3%

This is a slight memory usage increase due to the extra page pointer array.

The memory usage for scrubbing a 64KiB data is (the best case):

Old:   16 * (240 + 128) = 5888
New:   480 + 16 * 96    = 1944

Diff: -67.0%

In this case, the reduce in memory usage is awesome, almost cut 2/3 of the memory.

The memory usage for scrubbing a 4KiB data is (the worst case):
Old 240 + 128 = 368
New: 408 + 96 = 504
Diff: +37.0%

The memory usage for scrubbing a 8KiB data is:

Old:   2 * (240 + 128) = 736
New:   480 + 2 * 96    = 672

Diff: -8.7%

So as long as the extent is larger than 4KiB, the new patchset will use less memory usage, and the larger extent is, the better.

This is especially good as btrfs by default inline small (<=2K) data extents, thus we have much higher chance to larger data extents.

[PATCHSET STRUCTURE]
The first 3 patches are just cleanups, mostly to make scrub_sector allocation much easier.

The 4th patch is to introduce the new page array for sblock, and the 5th one to completely remove the usage of scrub_sector::page.

The last two are optimizations for both regular and subpage cases.

Qu Wenruo (7):
btrfs: scrub: use pointer array to replace @sblocks_for_recheck
btrfs: extract the initialization of scrub_block into a helper
function
btrfs: extract the allocation and initialization of scrub_sector into
a helper
btrfs: scrub: introduce scrub_block::pages for more efficient memory
usage for subpage
btrfs: scrub: remove scrub_sector::page and use scrub_block::pages
instead
btrfs: scrub: move logical/physical/dev/mirror_num from scrub_sector
to scrub_block
btrfs: use larger blocksize for data extent scrub

 fs/btrfs/scrub.c | 546 ++++++++++++++++++++++++++++++-----------------
 1 file changed, 353 insertions(+), 193 deletions(-)
Signature · 1 line
2.37.0