Skip to content

btrfs: inode creation cleanups and fixes

Omar Sandoval linux-btrfs 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 6 repliesIn review
  2. v34 patches 0 repliesSuperseded
  3. v216 patches 18 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v112 patches5 repliesSuperseded

Changes since v2 from the cover letter

- Mentioned reason for removal of btrfs_lookup_dentry() call in create_subvol() in commit message of patch 1.
- Made btrfs_init_inode_security() also take btrfs_new_inode_args in patch 2.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4btrfs: allocate inode outside of btrfs_new_inode()fs/btrfs/ctree.h fs/btrfs/inode.c fs/btrfs/ioctl.c+169 -1450 replies
2/4btrfs: factor out common part of btrfs_{mknod,create,mkdir}()fs/btrfs/inode.c+33 -1190 replies
3/4btrfs: reserve correct number of items for inode creationfs/btrfs/acl.c fs/btrfs/ctree.h fs/btrfs/inode.c +1 more+270 -1340 replies
4/4btrfs: move common inode creation code into btrfs_create_new_inode()fs/btrfs/ctree.h fs/btrfs/inode.c fs/btrfs/ioctl.c +2 more+180 -3334 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchSweet Tea Dorminy
1/4
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/4] btrfs: inode creation cleanups and fixes

From: Omar Sandoval <[email protected]>

This series contains minor updates of the final four patches of my previous series [1].

Based on misc-next with the previous version of "btrfs: allocate inode outside of btrfs_new_inode()" removed.

Changes since v3 [2]:

- Fixed a struct btrfs_root leak [3] in patch 1 which was fixed later in the same series by patch 3 for the sake of git bisect.

Changes since v2:

- Mentioned reason for removal of btrfs_lookup_dentry() call in create_subvol() in commit message of patch 1.
- Made btrfs_init_inode_security() also take btrfs_new_inode_args in patch 2.

Thanks!

1: https://lore.kernel.org/linux-btrfs/[email protected]/
2: https://lore.kernel.org/linux-btrfs/[email protected]/
3: https://lore.kernel.org/linux-btrfs/CAL3q7H5ACv3ej1=7P2y7mA1vCJoAcHkCqro6_VBuAUxeaw25rw@mail.gmail.com/

Omar Sandoval (4):
btrfs: allocate inode outside of btrfs_new_inode()
btrfs: factor out common part of btrfs_{mknod,create,mkdir}()
btrfs: reserve correct number of items for inode creation
btrfs: move common inode creation code into btrfs_create_new_inode()

 fs/btrfs/acl.c   |  36 +--
 fs/btrfs/ctree.h |  37 ++-
 fs/btrfs/inode.c | 800 +++++++++++++++++++++++------------------------
 fs/btrfs/ioctl.c | 140 +++++----
 fs/btrfs/props.c |  40 +--
 fs/btrfs/props.h |   4 -
 6 files changed, 489 insertions(+), 568 deletions(-)
Signature · 1 line
2.35.1