Skip to content

selftests: pmtu.sh: Fix cleanup of processes launched in subshell.

Guillaume Nault linux-kselftest netdev 1 version Applied

Status from this message: This series was applied to netdev/net.git (master)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesApplied 2/2

v2 from the cover letter

* Use tcpdump's immediate mode to capture packets even in short lived tests.
* Add patch 2 to fix the nettest_pids list.

Patches in v1 All 2 applied

#Subject and filesSizeRepliesApplied
1/2selftests: pmtu.sh: Kill tcpdump processes launched by subshell.tools/testing/selftests/net/pmtu.sh+5 -20 repliesApplied
2/2selftests: pmtu.sh: Kill nettest processes launched in subshell.tools/testing/selftests/net/pmtu.sh+12 -20 repliesApplied

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchShuah Khan
SeriesR-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net 0/2] selftests: pmtu.sh: Fix cleanup of processes launched in subshell.

Depending on the options used, pmtu.sh may launch tcpdump and nettest processes in the background. However it fails to clean them up after the tests complete.

Patch 1 allows the cleanup() function to read the list of PIDs launched by the tests.
Patch 2 fixes the way the nettest PIDs are retrieved.

v2:
* Use tcpdump's immediate mode to capture packets even in short lived tests.
* Add patch 2 to fix the nettest_pids list.

Guillaume Nault (2):
selftests: pmtu.sh: Kill tcpdump processes launched by subshell.
selftests: pmtu.sh: Kill nettest processes launched in subshell.

 tools/testing/selftests/net/pmtu.sh | 21 +++++++++++++++++----
 1 file changed, 17 insertions(+), 4 deletions(-)
Signature · 1 line
2.21.3