9pfs: fix 'Twalk' protocol violation
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest7 patches 8 repliesIn review
- v37 patches 2 repliesSuperseded
- v27 patches 1 replySuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 6 patches | 18 replies | Superseded |
Changes in v4 from the cover letter
* QID returned by Twalk request in fs_walk_2nd_nonexistent() test should NOT be identical to root node's QID. [patch 7]
* Fix actual 'fid unaffected' check in fs_walk_2nd_nonexistent() test by sending a subsequent 'Tgetattr' request. [patch 7]
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | tests/9pfs: walk to non-existent dirtests/ | +30 | 0 replies | |
| 2/7 | tests/9pfs: Twalk with nwname=0tests/ | +22 | 0 replies | |
| 3/7 | tests/9pfs: compare QIDs in fs_walk_none() testtests/ | +87 | 1 reply | |
| 4/7 | 9pfs: refactor 'name_idx' -> 'nwalked' in v9fs_walk()hw/ | +8 | 0 replies | |
| 5/7 | 9pfs: fix 'Twalk' to only send error if no component walkedhw/ | +27 | 3 replies | |
| 6/7 | tests/9pfs: guard recent 'Twalk' behaviour fixtests/ | +39 | 0 replies | |
| 7/7 | tests/9pfs: check fid being unaffected in fs_walk_2nd_nonexistenttests/ | +22 | 1 reply |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Greg Kurz |
|---|---|
| 1/7 | R-b |
| 2/7 | R-b |
| 3/7 | R-b |
| 4/7 | R-b |
| 5/7 | R-b |
| 6/7 | R-b |
| 7/7 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/7] 9pfs: fix 'Twalk' protocol violation
Currently the implementation of 'Twalk' does not behave exactly as specified by the 9p2000 protocol specification. Actual fix is patch 5; see the description of that patch for details of what this overall fix and series is about.
PREREQUISITES
=============
This series requires the following additional patch to work correctly:
https://lore.kernel.org/qemu-devel/[email protected]/
OVERVIEW OF PATCHES
===================
Patch 4 is a preparatory (pure) refactoring change to make actual 'Twalk' fix patch 5 better readable.
All the other patches are just additional test cases for guarding 'Twalk' behaviour.
v3 -> v4:
* QID returned by Twalk request in fs_walk_2nd_nonexistent() test should NOT be identical to root node's QID. [patch 7]
* Fix actual 'fid unaffected' check in fs_walk_2nd_nonexistent() test by sending a subsequent 'Tgetattr' request. [patch 7]
Christian Schoenebeck (7):
tests/9pfs: walk to non-existent dir
tests/9pfs: Twalk with nwname=0
tests/9pfs: compare QIDs in fs_walk_none() test
9pfs: refactor 'name_idx' -> 'nwalked' in v9fs_walk() 9pfs: fix 'Twalk' to only send error if no component walked tests/9pfs: guard recent 'Twalk' behaviour fix tests/9pfs: check fid being unaffected in fs_walk_2nd_nonexistent
hw/9pfs/9p.c | 57 ++++++---- tests/qtest/virtio-9p-test.c | 201 ++++++++++++++++++++++++++++++++++- 2 files changed, 231 insertions(+), 27 deletions(-)
Signature · 1 line
2.30.2