Skip to content

9pfs: fix 'Twalk' protocol violation

Christian Schoenebeck qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest7 patches 8 repliesIn review
  2. v37 patches 2 repliesSuperseded
  3. v27 patches 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v16 patches18 repliesSuperseded

Changes in v4 from the cover letter

* QID returned by Twalk request in fs_walk_2nd_nonexistent() test should NOT be identical to root node's QID. [patch 7]

* Fix actual 'fid unaffected' check in fs_walk_2nd_nonexistent() test by sending a subsequent 'Tgetattr' request. [patch 7]

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7tests/9pfs: walk to non-existent dirtests/qtest/virtio-9p-test.c+30 -00 replies
2/7tests/9pfs: Twalk with nwname=0tests/qtest/virtio-9p-test.c+22 -00 replies
3/7tests/9pfs: compare QIDs in fs_walk_none() testtests/qtest/virtio-9p-test.c+87 -01 reply
4/79pfs: refactor 'name_idx' -> 'nwalked' in v9fs_walk()hw/9pfs/9p.c+8 -80 replies
5/79pfs: fix 'Twalk' to only send error if no component walkedhw/9pfs/9p.c+27 -163 replies
6/7tests/9pfs: guard recent 'Twalk' behaviour fixtests/qtest/virtio-9p-test.c+39 -30 replies
7/7tests/9pfs: check fid being unaffected in fs_walk_2nd_nonexistenttests/qtest/virtio-9p-test.c+22 -41 reply

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchGreg Kurz
1/7R-b
2/7R-b
3/7R-b
4/7R-b
5/7R-b
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/7] 9pfs: fix 'Twalk' protocol violation

Currently the implementation of 'Twalk' does not behave exactly as specified by the 9p2000 protocol specification. Actual fix is patch 5; see the description of that patch for details of what this overall fix and series is about.

PREREQUISITES
=============

This series requires the following additional patch to work correctly:
https://lore.kernel.org/qemu-devel/[email protected]/

OVERVIEW OF PATCHES
===================

Patch 4 is a preparatory (pure) refactoring change to make actual 'Twalk' fix patch 5 better readable.

All the other patches are just additional test cases for guarding 'Twalk' behaviour.

v3 -> v4:

* QID returned by Twalk request in fs_walk_2nd_nonexistent() test should NOT be identical to root node's QID. [patch 7]

* Fix actual 'fid unaffected' check in fs_walk_2nd_nonexistent() test by sending a subsequent 'Tgetattr' request. [patch 7]

Christian Schoenebeck (7):
tests/9pfs: walk to non-existent dir
tests/9pfs: Twalk with nwname=0
tests/9pfs: compare QIDs in fs_walk_none() test
9pfs: refactor 'name_idx' -> 'nwalked' in v9fs_walk() 9pfs: fix 'Twalk' to only send error if no component walked tests/9pfs: guard recent 'Twalk' behaviour fix tests/9pfs: check fid being unaffected in fs_walk_2nd_nonexistent

 hw/9pfs/9p.c                 |  57 ++++++----
 tests/qtest/virtio-9p-test.c | 201 ++++++++++++++++++++++++++++++++++-
 2 files changed, 231 insertions(+), 27 deletions(-)
Signature · 1 line
2.30.2