protect relocation with sb_start_write
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest3 patches 2 repliesIn review
- v33 patches 2 repliesSuperseded
- v24 patches 10 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 4 patches | 7 replies | Superseded |
Changes in v4 from the cover letter
- Fix subject of patch 2 (Filipe)
- Revise the comment for the ASSERT (Filipe)
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | btrfs: mark resumed async balance as writingfs/ | +2 | 0 replies | |
| 2/3 | fs: add a check function for sb_start_write()include/ | +5 | 0 replies | |
| 3/3 | btrfs: assert that relocation is protected with sb_start_write()fs/ | +10 | 1 reply |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Filipe Manana |
|---|---|
| 1/3 | R-b |
| 2/3 | R-b |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/3] protect relocation with sb_start_write
This series is a follow-up to the series below [1]. The old series added an assertion to btrfs_relocate_chunk() to check if it is protected with sb_start_write(). However, it revealed another location we need to add sb_start_write() [2].
Also, this series moved the ASSERT from btrfs_relocate_chunk() to btrfs_relocate_block_group() because we do not need to call sb_start_write() on a non-data block group [3].
[1] https://lore.kernel.org/linux-btrfs/[email protected]/T/
[2] https://lore.kernel.org/linux-btrfs/[email protected]/T/#e06eecc07ce1cd1e45bfd30a374bd2d15b4fd76d8
[3] https://lore.kernel.org/linux-btrfs/[email protected]/
Patch 1 adds sb_{start,end}_write() to the resumed async balancing.
Patches 2 and 3 add an ASSERT to catch a future error.
--
v4:
- Fix subject of patch 2 (Filipe)
- Revise the comment for the ASSERT (Filipe)
v3:
- Only add sb_write_started(), which we really use. (Dave Chinner)
- Drop patch "btrfs: mark device addition as mnt_want_write_file" (Filipe Manana)
- Narrow asserting region to btrfs_relocate_block_group() and check only when the BG is data BG. (Filipe Manana)
v2:
- Use mnt_want_write_file() instead of sb_start_write() for btrfs_ioctl_add_dev()
- Drop bogus fixes tag
- Change the stable target to meaningful 4.9+
Naohiro Aota (3):
btrfs: mark resumed async balance as writing
fs: add a check function for sb_start_write()
btrfs: assert that relocation is protected with sb_start_write()
fs/btrfs/relocation.c | 10 ++++++++++ fs/btrfs/volumes.c | 2 ++ include/linux/fs.h | 5 +++++ 3 files changed, 17 insertions(+)
Signature · 1 line
2.35.1