Skip to content

perf/x86/amd/core: Add AMD PerfMonV2 support

Sandipan Das linux-perf-users lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest7 patches 13 repliesIn review
  2. v37 patches 2 repliesSuperseded
  3. v27 patches 4 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v17 patches14 repliesSuperseded

Changes in v4 from the cover letter

- Use ARCH_PERFMON feature bit instead of vendor info to determine the availability of CPUID leaf 0xA.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7x86/cpufeatures: Add PerfMonV2 feature bitarch/x86/include/asm/cpufeatures.h arch/x86/kernel/cpu/scattered.c+2 -10 replies
2/7x86/msr: Add PerfCntrGlobal* registersarch/x86/include/asm/msr-index.h+5 -00 replies
3/7perf/x86/amd/core: Detect PerfMonV2 supportarch/x86/events/amd/core.c+27 -04 replies
4/7perf/x86/amd/core: Detect available countersarch/x86/events/amd/core.c arch/x86/include/asm/perf_event.h+23 -00 replies
5/7perf/x86/amd/core: Add PerfMonV2 counter controlarch/x86/events/amd/core.c+45 -53 replies
6/7perf/x86/amd/core: Add PerfMonV2 overflow handlingarch/x86/events/amd/core.c+133 -112 replies
7/7kvm: x86/cpuid: Fix CPUID leaf 0xAarch/x86/kvm/cpuid.c+5 -03 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/7] perf/x86/amd/core: Add AMD PerfMonV2 support

Add support for using AMD Performance Monitoring Version 2 (PerfMonV2) features on upcoming processors. New CPU features are introduced for PerfMonV2 detection. New MSR definitions are added to make use of an alternative PMC management scheme based on the new PMC global control and status registers.

The global control register provides the ability to start and stop multiple PMCs at the same time. This makes it possible to enable or disable all counters with a single MSR write instead of writing to the individual PMC control registers iteratively under x86_pmu_{enable,disable}(). The effects can be seen when counting the same events across multiple PMCs.

E.g.

  $ sudo perf stat -e "{cycles,instructions,cycles,instructions}" sleep 1

Before:

Performance counter stats for 'sleep 1':

             1013281      cycles
             1452859      instructions              #    1.43  insn per cycle
             1023462      cycles
             1461724      instructions              #    1.43  insn per cycle
         1.001644276 seconds time elapsed
  
         0.001948000 seconds user
         0.000000000 seconds sys

After:

Performance counter stats for 'sleep 1':

              999165      cycles
             1440456      instructions              #    1.44  insn per cycle
              999165      cycles
             1440456      instructions              #    1.44  insn per cycle
         1.001879504 seconds time elapsed
  
         0.001817000 seconds user
         0.000000000 seconds sys

No additional failures are seen upon running the following:
* perf built-in test suite
* perf_event_tests suite
* rr test suite

Previous versions can be found at:
v3: https://lore.kernel.org/all/[email protected]/
v2: https://lore.kernel.org/all/[email protected]/
v1: https://lore.kernel.org/all/[email protected]/

Changes in v4:
- Use ARCH_PERFMON feature bit instead of vendor info to determine the availability of CPUID leaf 0xA.

Changes in v3:
- Remove unused parameter from amd_pmu_cpu_reset().
- Add Hygon as a vendor that does not support CPUID leaf 0xA.

Changes in v2:
- Sort PerfCntrGlobal* register definitions based on MSR index.
- Use wrmsrl() in cpu_{starting,dead}().
- Add enum to extract bitfields from CPUID leaf 0x80000022.
- Remove static calls for counter management functions.
- Stop counters before inspecting overflow status in NMI handler.
- Save and restore PMU enabled state in NMI handler.
- Remove unused variable in NMI handler.
- Remove redundant write to APIC_LVTPC in NMI handler.
- Add comment on APIC_LVTPC mask bit behaviour during counter overflow.

Sandipan Das (7):
x86/cpufeatures: Add PerfMonV2 feature bit x86/msr: Add PerfCntrGlobal* registers perf/x86/amd/core: Detect PerfMonV2 support perf/x86/amd/core: Detect available counters perf/x86/amd/core: Add PerfMonV2 counter control perf/x86/amd/core: Add PerfMonV2 overflow handling
kvm: x86/cpuid: Fix CPUID leaf 0xA

 arch/x86/events/amd/core.c         | 227 +++++++++++++++++++++++++++--
 arch/x86/include/asm/cpufeatures.h |   2 +-
 arch/x86/include/asm/msr-index.h   |   5 +
 arch/x86/include/asm/perf_event.h  |  17 +++
 arch/x86/kernel/cpu/scattered.c    |   1 +
 arch/x86/kvm/cpuid.c               |   5 +
 6 files changed, 240 insertions(+), 17 deletions(-)
Signature · 1 line
2.34.1