Skip to content

RFC drm/edid: overhaul CEA data block iteration

Jani Nikula amd-gfx dri-devel intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest19 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19drm/edid: add drm_edid_extension_block_count() and drm_edid_size()drivers/gpu/drm/drm_edid.c include/drm/drm_edid.h+20 -01 reply
2/19drm: use drm_edid_extension_block_count() and drm_edid_size()drivers/gpu/drm/drm_connector.c drivers/gpu/drm/drm_debugfs.c drivers/gpu/drm/drm_edid.c+9 -101 reply
3/19drm/edid: clean up CEA data block tag definitionsdrivers/gpu/drm/drm_edid.c+32 -271 reply
4/19drm/edid: add iterator for EDID base and extension blocksdrivers/gpu/drm/drm_edid.c+46 -00 replies
5/19drm/edid: add iterator for CEA data blocksdrivers/gpu/drm/drm_edid.c+186 -121 reply
6/19drm/edid: clean up cea_db_is_*() functionsdrivers/gpu/drm/drm_edid.c+37 -762 replies
7/19drm/edid: convert add_cea_modes() to use cea db iterdrivers/gpu/drm/drm_edid.c+31 -360 replies
8/19drm/edid: convert drm_edid_to_speaker_allocation() to use cea db iterdrivers/gpu/drm/drm_edid.c+15 -320 replies
9/19drm/edid: convert drm_edid_to_sad() to use cea db iterdrivers/gpu/drm/drm_edid.c+9 -251 reply
10/19drm/edid: convert drm_detect_hdmi_monitor() to use cea db iterdrivers/gpu/drm/drm_edid.c+11 -140 replies
11/19drm/edid: convert drm_detect_monitor_audio() to use cea db iterdrivers/gpu/drm/drm_edid.c+13 -100 replies
12/19drm/edid: convert drm_parse_cea_ext() to use cea db iterdrivers/gpu/drm/drm_edid.c+13 -120 replies
13/19drm/edid: convert drm_edid_to_eld() to use cea db iterdrivers/gpu/drm/drm_edid.c+29 -350 replies
14/19drm/edid: sunset the old unused cea data block iteratorsdrivers/gpu/drm/drm_edid.c+0 -450 replies
15/19drm/edid: restore some type safety to cea_db_*() functionsdrivers/gpu/drm/drm_edid.c+8 -110 replies
16/19drm/edid: detect basic audio only on CEA extensiondrivers/gpu/drm/drm_edid.c+11 -60 replies
17/19drm/edid: detect color formats and CEA revision only on CEA extensiondrivers/gpu/drm/drm_edid.c+20 -110 replies
18/19drm/edid: skip CEA extension scan in drm_edid_to_eld() just for CEA revdrivers/gpu/drm/drm_edid.c+5 -100 replies
19/19drm/edid: sunset drm_find_cea_extension()drivers/gpu/drm/drm_edid.c+8 -91 reply

Reviews trailers per patch

5 of 19 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchVille Syrjälä
SeriesR-b
1/19R-b
2/19R-b
3/19R-b
4/19
5/19R-b
6/19R-b
7/19
8/19
9/19
10/19
11/19
12/19
13/19
14/19
15/19
16/19
17/19
18/19
19/19

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC 00/19] drm/edid: overhaul CEA data block iteration

Add iterators for EDID blocks and CEA data blocks, to iterate through all data blocks across all CEA extensions and CTA blocks in DisplayID data blocks. Fix all code assuming only one CEA extension. Fix code assuming CTA blocks contain everything that CEA extensions do. Sprinkle a bunch of cleanups on top.

This is completely UNTESTED, didn't even smoke test it. It builds. ;)

This superseeds parts of [1] and [2].

BR,
Jani.

[1] https://patchwork.freedesktop.org/series/101241/
[2] https://patchwork.freedesktop.org/patch/msgid/[email protected]

Jani Nikula (19):
drm/edid: add drm_edid_extension_block_count() and drm_edid_size()
drm: use drm_edid_extension_block_count() and drm_edid_size() drm/edid: clean up CEA data block tag definitions drm/edid: add iterator for EDID base and extension blocks drm/edid: add iterator for CEA data blocks
drm/edid: clean up cea_db_is_*() functions
drm/edid: convert add_cea_modes() to use cea db iter drm/edid: convert drm_edid_to_speaker_allocation() to use cea db iter drm/edid: convert drm_edid_to_sad() to use cea db iter drm/edid: convert drm_detect_hdmi_monitor() to use cea db iter drm/edid: convert drm_detect_monitor_audio() to use cea db iter drm/edid: convert drm_parse_cea_ext() to use cea db iter drm/edid: convert drm_edid_to_eld() to use cea db iter drm/edid: sunset the old unused cea data block iterators drm/edid: restore some type safety to cea_db_*() functions drm/edid: detect basic audio only on CEA extension drm/edid: detect color formats and CEA revision only on CEA extension drm/edid: skip CEA extension scan in drm_edid_to_eld() just for CEA
rev
drm/edid: sunset drm_find_cea_extension()

 drivers/gpu/drm/drm_connector.c |   2 +-
 drivers/gpu/drm/drm_debugfs.c   |   3 +-
 drivers/gpu/drm/drm_edid.c      | 781 ++++++++++++++++++--------------
 include/drm/drm_edid.h          |   2 +
 4 files changed, 455 insertions(+), 333 deletions(-)
Signature · 1 line
2.30.2