tr2: avoid to print "interesting" config repeatedly
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest5 patches 16 repliesIn review
- v3 posting 2/20 of 5 patches 0 repliesSuperseded
- v3 posting 1/25 patches 12 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 5 patches | 12 replies | Superseded | |
| v1 | 3 patches | 14 replies | Superseded |
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | pack-bitmap.c: continue looping when first MIDX bitmap is foundpack-bitmap.c | +3 | 0 replies | |
| 2/5 | pack-bitmap.c: rename "idx_name" to "bitmap_name"pack-bitmap.c | +7 | 0 replies | |
| 3/5 | pack-bitmap.c: using error() instead of silently returning -1pack-bitmap.c | +5 | 3 replies | |
| 4/5 | pack-bitmap.c: retrieve missing i18n translationspack-bitmap.c | +38 | 8 replies | |
| 5/5 | tr2: avoid to print "interesting" config repeatedlytrace2/ | +8 | 5 replies |
Reviews trailers per patch
None of the 5 patches has a Reviewed-by or Acked-by.
| Patch | Taylor Blau | Jeff Hostetler |
|---|---|---|
| Series | Helped-by Helped-by Helped-by | |
| 1/5 | Helped-by | |
| 2/5 | ||
| 3/5 | ||
| 4/5 | ||
| 5/5 | Helped-by |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v5 0/5] tr2: avoid to print "interesting" config repeatedly
Changes since v4:
By Jeff Hostetler's suggestion, we can use GIT_TRACE2_CONFIG_PARAMS and trace2.configparams to dump "interesting" config values to the trace2 log. So I drop the commit [5/5] 'bitmap: add trace2 outputs during open "bitmap" file' in v4.
Then I found if a config key exist multiple config values in different scope the trace2 log will print the value repeatly but not only print the final active value, so a new commit "avoid to print "interesting" config repeatedly" is appended in v5.
Finally, compared with [3/5] in v4, commit "pack-bitmap.c: retrieve missing i18n translations" fix every place which was missing translation in pack-bitmap.c.
Thanks.
Teng Long (5):
pack-bitmap.c: continue looping when first MIDX bitmap is found pack-bitmap.c: rename "idx_name" to "bitmap_name" pack-bitmap.c: using error() instead of silently returning -1 pack-bitmap.c: retrieve missing i18n translations
tr2: avoid to print "interesting" config repeatedly
pack-bitmap.c | 105 ++++++++++++++++++++++++----------------------- trace2/tr2_cfg.c | 9 +++- 2 files changed, 61 insertions(+), 53 deletions(-)
Range-diff against v4:
1: d8dfe53dd4 < -: ---------- pack-bitmap.c: make warnings support i18N when opening bitmap -: ---------- > 1: 589e3f4075 pack-bitmap.c: continue looping when first MIDX bitmap is found -: ---------- > 2: b6b30047fc pack-bitmap.c: rename "idx_name" to "bitmap_name" 2: 917551f2b5 = 3: 82d4493a6e pack-bitmap.c: using error() instead of silently returning -1 3: 8735ae9979 < -: ---------- bitmap: add trace2 outputs during open "bitmap" file -: ---------- > 4: 065b7c9ccb pack-bitmap.c: retrieve missing i18n translations -: ---------- > 5: f3b87a33da tr2: avoid to print "interesting" config repeatedly
Signature · 1 line
2.35.1.582.gf3b87a33da