Skip to content

drm/edid: constify EDID parsing, with fixes

Jani Nikula dri-devel intel-gfx 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest12 patches 14 repliesIn review
  2. v211 patches 4 repliesSuperseded
  3. v19 patches 3 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12drm/edid: don't modify EDID while parsingdrivers/gpu/drm/drm_edid.c+9 -90 replies
2/12drm/edid: fix reduced blanking support checkdrivers/gpu/drm/drm_edid.c+1 -11 reply
3/12drm/edid: pass a timing pointer to is_display_descriptor()drivers/gpu/drm/drm_edid.c+16 -111 reply
4/12drm/edid: pass a timing pointer to is_detailed_timing_descriptor()drivers/gpu/drm/drm_edid.c+5 -31 reply
5/12drm/edid: use struct detailed_timing member access in is_rb()drivers/gpu/drm/drm_edid.c+9 -51 reply
6/12drm/edid: use struct detailed_timing member access in gtf2 functionsdrivers/gpu/drm/drm_edid.c+37 -201 reply
7/12drm/edid: constify struct detailed_timing in lower level parsingdrivers/gpu/drm/drm_edid.c+20 -201 reply
8/12drm/edid: constify struct detailed_timing in parsing callbacksdrivers/gpu/drm/drm_edid.c+21 -191 reply
9/12drm/edid: constify struct edid passed to detailed blocksdrivers/gpu/drm/drm_edid.c+23 -251 reply
10/12drm/edid: constify struct edid passed around in callbacks and closuredrivers/gpu/drm/drm_edid.c+24 -241 reply
11/12drm/edid: add more general struct edid constness in the interfacesdrivers/gpu/drm/drm_edid.c include/drm/drm_edid.h+16 -151 reply
12/12drm/edid: split drm_add_edid_modes() to twodrivers/gpu/drm/drm_edid.c+24 -182 replies

Reviews trailers per patch

All 12 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchVille SyrjäläEmil Velikov
SeriesR-b
1/12R-b
2/12R-b
3/12R-b
4/12R-b
5/12R-b
6/12R-b
7/12R-b
8/12R-b
9/12R-b
10/12R-b
11/12R-b
12/12R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/12] drm/edid: constify EDID parsing, with fixes

v3 of https://patchwork.freedesktop.org/series/101787/ and
https://patchwork.freedesktop.org/series/101862/

I screwed up with the struct renamings in v2, so there's some falling back to v1 and general confusion here. Sorry.

BR,
Jani.

Jani Nikula (12):
drm/edid: don't modify EDID while parsing
drm/edid: fix reduced blanking support check
drm/edid: pass a timing pointer to is_display_descriptor() drm/edid: pass a timing pointer to is_detailed_timing_descriptor() drm/edid: use struct detailed_timing member access in is_rb() drm/edid: use struct detailed_timing member access in gtf2 functions drm/edid: constify struct detailed_timing in lower level parsing drm/edid: constify struct detailed_timing in parsing callbacks drm/edid: constify struct edid passed to detailed blocks drm/edid: constify struct edid passed around in callbacks and closure drm/edid: add more general struct edid constness in the interfaces drm/edid: split drm_add_edid_modes() to two

 drivers/gpu/drm/drm_edid.c | 325 ++++++++++++++++++++-----------------
 include/drm/drm_edid.h     |  10 +-
 2 files changed, 185 insertions(+), 150 deletions(-)
Signature · 1 line
2.30.2