Skip to content

btrfs: allocate page arrays more efficiently

Sweet Tea Dorminy linux-btrfs lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 4 repliesIn review
  2. v22 patches 3 repliesSuperseded
  3. v12 patches 6 repliesSuperseded

Changes in v3 from the cover letter

- fixed up the other style comments from kdave's v1 comments

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2btrfs: factor out allocating an array of pagesfs/btrfs/check-integrity.c fs/btrfs/compression.c fs/btrfs/extent_io.c +3 more+79 -751 reply
2/2btrfs: allocate page arrays using bulk page allocatorfs/btrfs/extent_io.c+15 -93 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchNikolay Borisov
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] btrfs: allocate page arrays more efficiently

In several places, btrfs allocates an array of pages, one at a time. In addition to duplicating code, the mm subsystem provides a helper to allocate multiple pages at once into an array which is suited for our usecase. In the fast path, the batching can result in better allocation decisions and less locking. This changeset first adjusts the users to call a common array-of-pages allocation function, then adjusts that common function to use the batch page allocator.

v3:
- fixed up the other style comments from kdave's v1 comments
v2:
- moved new helper to extent_io.[ch]; fixed title format
- https://lore.kernel.org/linux-btrfs/[email protected]/
v1:
- https://lore.kernel.org/linux-btrfs/[email protected]/

Sweet Tea Dorminy (2):
btrfs: factor out allocating an array of pages
btrfs: allocate page arrays using bulk page allocator

 fs/btrfs/check-integrity.c |  8 ++---
 fs/btrfs/compression.c     | 39 +++++++++------------
 fs/btrfs/extent_io.c       | 71 +++++++++++++++++++++++++++++---------
 fs/btrfs/extent_io.h       |  2 ++
 fs/btrfs/inode.c           | 10 +++---
 fs/btrfs/raid56.c          | 30 +++-------------
 6 files changed, 85 insertions(+), 75 deletions(-)
Signature · 1 line
2.35.1