Skip to content

rlt8723bs cleanup

Sevinj Aghayeva linux-staging lkml outreachy 3 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 6 repliesIn review
  2. v23 patches 1 replySuperseded
  3. v13 patches 3 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3staging: rtl8723bs: remove redundant braces in if statementsdrivers/staging/rtl8723bs/core/rtw_mlme_ext.c+26 -506 replies
2/3staging: rtl8723bs: place constants on the right side of testsdrivers/staging/rtl8723bs/core/rtw_mlme_ext.c+17 -170 replies
3/3staging: rtl8723bs: remove redundant else branchesdrivers/staging/rtl8723bs/core/rtw_mlme_ext.c+30 -330 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/3] rlt8723bs cleanup

These patches fix three categories of checkpatch warnings (redundant braces, redundant else branches after return/break, and constant placements on tests) in file rtw_mlme_ext.c, which is part of the rtl8723bs driver. False positives, such as

if (foo) {
	/* TODO: ... */
}

were not altered.

---
v1 -> v2: Removing a redundant else branch left a variable declaration mixed with code, which was caught by the kernel test bot. Move the declaration to the beginning of a function.

v3 -> v2: Include correct files in the patchset.
---

Sevinj Aghayeva (3):
staging: rtl8723bs: remove redundant braces in if statements
staging: rtl8723bs: place constants on the right side of tests
staging: rtl8723bs: remove redundant else branches

 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 167 ++++++++----------
 1 file changed, 70 insertions(+), 97 deletions(-)
Signature · 1 line
2.25.1