Skip to content

BPF round-robin scheduler

Geliang Tang mptcp 15 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v15 Latest2 patches 0 repliesNew
  2. v143 patches 1 replySuperseded
  3. v133 patches 2 repliesSuperseded
Earlier versions · 12
VersionPostedPatchesRepliesStatus
v123 patches4 repliesSuperseded
v113 patches1 replySuperseded
v103 patches1 replySuperseded
v93 patches2 repliesSuperseded
v83 patches1 replySuperseded
v73 patches0 repliesSuperseded
v63 patches0 repliesSuperseded
v54 patches0 repliesSuperseded
v44 patches1 replySuperseded
v34 patches0 repliesSuperseded
v23 patches0 repliesSuperseded
v13 patches0 repliesSuperseded

Changes in v15 from the cover letter

- use the new BPF scheduler API
- verify data was sent on new subflow in 'ss' output
- depends on "BPF packet scheduler" v2

Patches in v15 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2selftests/bpf: add bpf_rr schedulertools/testing/selftests/bpf/bpf_tcp_helpers.h tools/testing/selftests/bpf/progs/mptcp_bpf_rr.c+49 -00 replies
2/2selftests/bpf: add bpf_rr testtools/testing/selftests/bpf/prog_tests/mptcp.c+39 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v15 yet.

Read the v15 thread

Cover letter [PATCH mptcp-next v15 0/2] BPF round-robin scheduler

v15:
- use the new BPF scheduler API
- verify data was sent on new subflow in 'ss' output
- depends on "BPF packet scheduler" v2

v14:
- export subflows number in patch 1, it will be used in redundant scheduler.
- rebased on "update bpf patches on export branch" v2.

v13:
- add !msk->last_snd check in patch 2
- use ASSERT_OK_PTR instead of CHECK in patch 3
- base-commit: export/20220509T115202

v12:
- init ssk from data->contexts[0], instead of msk->first.
- cycle through all the subflows, instead of the first two.

v11:
- rename array to contexts.
- drop number of subflows in mptcp_sched_data.
- set unused array elements to NULL.
- add MPTCP_SUBFLOWS_MAX check in mptcp_sched_data_init.

v10:
- init subflows array in mptcp_sched_data_init.
- for (int i = 0; i < data->subflows; i++) is not allowed in BPF, using this instead:

        for (int i = 0; i < MPTCP_SUBFLOWS_MAX && i < data->subflows; i++)

- deponds on: "BPF packet scheduler" series v18.

v9:
- add subflows array in mptcp_sched_data
- deponds on: "BPF packet scheduler" series v17 + Squash to "mptcp: add struct mptcp_sched_ops v17".

v8:
- use struct mptcp_sched_data.
- deponds on: "BPF packet scheduler" series v14.

v7:
- rename retrans to reinject.
- drop last_snd setting.
- deponds on: "BPF packet scheduler" series v13.

v6:
- set call_me_again flag.
- deponds on: "BPF packet scheduler" series v12.

v5:
- update patch 2, use temporary storage instead.
- update patch 3, use new helpers.
- deponds on: "BPF packet scheduler" series v11.

v4:
- add retrans argment for get_subflow()

v3:
- add last_snd write access.
- keep msk->last_snd setting in get_subflow().
- deponds on: "BPF packet scheduler" series v10.

v2:
- merge the squash-to patch.
- implement bpf_mptcp_get_subflows helper, instead of bpf_mptcp_get_next_subflow.
- deponds on: "BPF packet scheduler v9".

This patchset implements round-robin scheduler using BPF. Address to some commends for the RFC version:

https://patchwork.kernel.org/project/mptcp/cover/[email protected]/

Geliang Tang (2):
selftests/bpf: add bpf_rr scheduler
selftests/bpf: add bpf_rr test

 tools/testing/selftests/bpf/bpf_tcp_helpers.h |  1 +
 .../testing/selftests/bpf/prog_tests/mptcp.c  | 39 +++++++++++++++
 .../selftests/bpf/progs/mptcp_bpf_rr.c        | 48 +++++++++++++++++++
 3 files changed, 88 insertions(+)
 create mode 100644 tools/testing/selftests/bpf/progs/mptcp_bpf_rr.c
Signature · 1 line
2.34.1