Skip to content

btrfs-progs: add RAID56 rebuild ability at read time

Qu Wenruo linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8btrfs-progs: remove the unnecessary BTRFS_SUPER_INFO_OFFSET path for tree block readkernel-shared/disk-io.c+1 -20 replies
2/8btrfs-progs: extract metadata restore read code into its own helperkernel-shared/disk-io.c+42 -270 replies
3/8btrfs-progs: don't use write_extent_to_disk() directlybtrfs-corrupt-block.c+2 -20 replies
4/8btrfs-progs: use write_data_to_disk() to replace write_extent_to_disk()kernel-shared/disk-io.c kernel-shared/extent_io.c kernel-shared/extent_io.h +1 more+19 -320 replies
5/8btrfs-progs: use read_data_from_disk() to replace read_extent_from_disk() and replace read_extent_data()btrfs-corrupt-block.c btrfs-map-logical.c btrfstune.c +10 more+80 -1730 replies
6/8btrfs-progs: remove extent_buffer::fd and extent_buffer::dev_bytesbtrfs-corrupt-block.c kernel-shared/ctree.c kernel-shared/extent_io.c +2 more+7 -190 replies
7/8btrfs-progs: allow read_data_from_disk() to rebuild RAID56 using P/Qkernel-shared/extent_io.c kernel-shared/volumes.c kernel-shared/volumes.h+128 -140 replies
8/8btrfs-progs: tests/fsck: add test case for data csum check on raid5tests/fsck-tests/056-raid56-false-alerts/test.sh+31 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/8] btrfs-progs: add RAID56 rebuild ability at read time

This branch can be fetched from github:
https://github.com/adam900710/btrfs-progs/tree/raid56_rebuild

Please note that, the last time I check devel branch, the RAID56 warning patch is not yet merged.

So this is based on the latest devel branch from github.

And since we're adding proper RAID56 repair ability, there is no need
for the patchset "btrfs-progs: check: avoid false alerts for --check-data-csum on RAID56"

This patchset is mostly to add the ability to properly read data/metadata for RAID56 when mirror_num > 1.

[PROBLEMS]
There are several for current btrfs-progs:

- No RAID56 rebuild ability
Thus for any mirror > 1 on RAID56, we will read the parity data straight, causing no way to recover.

- No unified logical read/write entrance
We have various different functions, for read we have read_data_from_disk(), read_extent_data() and read_extent_from_disk().

Unlike kernel, we have no btrfs_map_bio() to address everything.

This makes adding RAID56 rebuild even hard.

[FIXES]
To address the problem, this patchset will:

- Cleanup and refactors
Mostly to unify the logical read/write entrance.
In patch 1~6, we will unify the logical read write entrances to only two functions:
* read_extent_from_disk()
* write_extent_to_disk()

They will do the chunk mapping and stripe splitting.

- Add RAID56 read rebuild ability
We already have RAID56 RMW for write path. Just add a new helper for mirror > 1 read on RAID56.

- A new test case
In fact the same test case from previous RAID56 warning patchset.

Qu Wenruo (8):
btrfs-progs: remove the unnecessary BTRFS_SUPER_INFO_OFFSET path for
tree block read
btrfs-progs: extract metadata restore read code into its own helper
btrfs-progs: don't use write_extent_to_disk() directly
btrfs-progs: use write_data_to_disk() to replace
write_extent_to_disk()
btrfs-progs: use read_data_from_disk() to replace
read_extent_from_disk() and replace read_extent_data()
btrfs-progs: remove extent_buffer::fd and extent_buffer::dev_bytes
btrfs-progs: allow read_data_from_disk() to rebuild RAID56 using P/Q
btrfs-progs: tests/fsck: add test case for data csum check on raid5

 btrfs-corrupt-block.c                         |  38 +---
 btrfs-map-logical.c                           |   5 +-
 btrfstune.c                                   |   3 +-
 check/main.c                                  |   2 +-
 check/mode-common.c                           |   4 +-
 cmds/restore.c                                |   4 +-
 image/main.c                                  |   2 +-
 kernel-shared/ctree.c                         |   5 +-
 kernel-shared/disk-io.c                       | 140 +++++--------
 kernel-shared/disk-io.h                       |   2 -
 kernel-shared/extent_io.c                     | 188 ++++++++++++------
 kernel-shared/extent_io.h                     |   9 +-
 kernel-shared/file.c                          |  20 +-
 kernel-shared/free-space-cache.c              |  20 +-
 kernel-shared/volumes.c                       |  39 ++--
 kernel-shared/volumes.h                       |   1 +
 .../056-raid56-false-alerts/test.sh           |  31 +++
 17 files changed, 277 insertions(+), 236 deletions(-)
 create mode 100755 tests/fsck-tests/056-raid56-false-alerts/test.sh
Signature · 1 line
2.35.1