Skip to content

DRM: Bridge: DW_HDMI: Add new features and bug fix

[email protected] dri-devel lkml 3 versions – Applied

Status from this message: Applied to drm-misc-next.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 3 repliesApplied
  2. v25 patches 12 repliesSuperseded
  3. v15 patches 10 repliesSuperseded

Changes in v3 from the cover letter

1. Drop the patch of Add CEC Suspend/Resume to restore registers. Because it is not a general feature for other SOCs, their CEC engine are enabled in suspend for CEC wakeup.
2. More detail comments for patch GCP only for Deep Color.
3. Address coments for patch GPA driver and move enable_audio/disable_audio from dw_hdmi_phy_ops to dw_hdmi_plat_data.

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/4drm: bridge: dw_hdmi: default enable workaround to clear the overflowdrivers/gpu/drm/bridge/synopsys/dw-hdmi.c+7 -160 replies
2/4drm: bridge: dw_hdmi: Enable GCP only for Deep Colordrivers/gpu/drm/bridge/synopsys/dw-hdmi.c drivers/gpu/drm/bridge/synopsys/dw-hdmi.h+20 -01 reply
3/4drm: bridge: dw_hdmi: add reset function for PHY GEN1drivers/gpu/drm/bridge/synopsys/dw-hdmi.c drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c include/drm/bridge/dw_hdmi.h+15 -50 replies
4/4drm: bridge: dw_hdmi: Audio: Add General Parallel Audio (GPA) driverdrivers/gpu/drm/bridge/synopsys/Kconfig drivers/gpu/drm/bridge/synopsys/Makefile drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c +3 more+358 -41 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchNeil ArmstrongJernej Skrabec
1/4A-b
2/4R-b
3/4R-b A-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] DRM: Bridge: DW_HDMI: Add new features and bug fix

From: Sandor Yu <[email protected]>

This is new features and bug fix patch set for DW_HDMI DRM bridge driver that has verified by NXP i.MX8MPlus.
Two new feature added:
1. Add GPA interface for DW_HDMI Audio.
3. New API for reset PHY Gen1.
Two bugs fixed:
1. Enable overflow workaround for all IP versions later than v1.30a.
2. Clear GCP_Auto bit for 24-bit color depth to pass CTS.

v1->v2:
1. Save CEC interrupt registers in struct dw_hdmi_cec
2. Restore CEC logical address register by cec->addresses.
3. Default enable overflow workaround for all versions later than v1.30a.
4. Add clear_gcp_auto flag to clear gcp_auto bit for all 24-bit color.
5. Remove i.MX8MPlus specific reference.

v2->v3:
1. Drop the patch of Add CEC Suspend/Resume to restore registers. Because it is not a general feature for other SOCs, their CEC engine are enabled in suspend for CEC wakeup.
2. More detail comments for patch GCP only for Deep Color.
3. Address coments for patch GPA driver and move enable_audio/disable_audio from dw_hdmi_phy_ops to dw_hdmi_plat_data.

Sandor Yu (4):
drm: bridge: dw_hdmi: default enable workaround to clear the overflow
drm: bridge: dw_hdmi: Enable GCP only for Deep Color
drm: bridge: dw_hdmi: add reset function for PHY GEN1
drm: bridge: dw_hdmi: Audio: Add General Parallel Audio (GPA) driver

 drivers/gpu/drm/bridge/synopsys/Kconfig       |  10 +
 drivers/gpu/drm/bridge/synopsys/Makefile      |   1 +
 .../drm/bridge/synopsys/dw-hdmi-gp-audio.c    | 199 ++++++++++++++++++
 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c     | 186 ++++++++++++++--
 drivers/gpu/drm/bridge/synopsys/dw-hdmi.h     |  16 +-
 drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c        |   2 +-
 include/drm/bridge/dw_hdmi.h                  |  11 +-
 7 files changed, 400 insertions(+), 25 deletions(-)
 create mode 100644 drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c
Signature · 1 line
2.25.1