Skip to content

ipv4: Convert several tos fields to dscp_t

Guillaume Nault netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 9 repliesApplied 5/5

Patches in v1 All 5 applied

#Subject and filesSizeRepliesApplied
1/5ipv4: Use dscp_t in struct fib_rt_infodrivers/net/ethernet/marvell/prestera/prestera_router.c drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c drivers/net/netdevsim/fib.c +4 more+17 -142 repliesApplied
2/5ipv4: Use dscp_t in struct fib_entry_notifier_infodrivers/net/ethernet/marvell/prestera/prestera_router.c drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c drivers/net/netdevsim/fib.c +2 more+11 -112 repliesApplied
3/5netdevsim: Use dscp_t in struct nsim_fib4_rtdrivers/net/netdevsim/fib.c+3 -33 repliesApplied
4/5mlxsw: Use dscp_t in struct mlxsw_sp_fib4_entrydrivers/net/ethernet/mellanox/mlxsw/spectrum_router.c+6 -61 replyApplied
5/5net: marvell: prestera: Use dscp_t in struct prestera_kern_fib_cachedrivers/net/ethernet/marvell/prestera/prestera_router.c+3 -31 replyApplied

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchJakub KicinskiIdo SchimmelDavid AhernYevhen Orlov
1/5R-b R-b
2/5R-b R-b
3/5A-b R-b R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH net-next 0/5] ipv4: Convert several tos fields to dscp_t

Continue the work started with commit a410a0cf9885 ("ipv6: Define dscp_t and stop taking ECN bits into account in fib6-rules") and convert more structure fields and variables to dscp_t. This series focuses on struct fib_rt_info, struct fib_entry_notifier_info and their users (networking drivers).

The purpose of dscp_t is to ensure that ECN bits don't influence IP route lookups. It does so by ensuring that dscp_t variables have the ECN bits cleared.

Notes:
* This series is entirely about type annotation and isn't supposed
to have any user visible effect.

* The first two patches have to introduce a few dsfield <-> dscp
conversions in the affected drivers, but those are then removed when converting the internal driver structures (patches 3-5). In the end, drivers don't have to handle any conversion.

Guillaume Nault (5):
ipv4: Use dscp_t in struct fib_rt_info
ipv4: Use dscp_t in struct fib_entry_notifier_info
netdevsim: Use dscp_t in struct nsim_fib4_rt
mlxsw: Use dscp_t in struct mlxsw_sp_fib4_entry
net: marvell: prestera: Use dscp_t in struct prestera_kern_fib_cache

 .../ethernet/marvell/prestera/prestera_router.c   | 11 ++++++-----
 .../net/ethernet/mellanox/mlxsw/spectrum_router.c | 15 ++++++++-------
 drivers/net/netdevsim/fib.c                       |  9 +++++----
 include/net/ip_fib.h                              |  4 ++--
 net/ipv4/fib_semantics.c                          |  4 ++--
 net/ipv4/fib_trie.c                               | 10 +++++-----
 net/ipv4/route.c                                  |  4 ++--
 7 files changed, 30 insertions(+), 27 deletions(-)
Signature · 1 line
2.21.3