RFC mptcp: improve mptcp-level window tracking
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest4 patches 3 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | mptcp: really share subflow snd_wndnet/ | +15 | 0 replies | |
| 2/4 | mptcp: add mib for xmit window sharingnet/ net/ net/ | +5 | 0 replies | |
| 3/4 | mptcp: never shrink offered windowinclude/ net/ net/ | +51 | 1 reply | |
| 4/4 | mptcp: add more offered MIBs counter.net/ net/ net/ | +13 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC PATCH 0/4] mptcp: improve mptcp-level window tracking
I've been chasing bad/unstable performances with multiple subflows on very high speed links.
It looks like the root cause is due to the current mptcp-level congestion window handling. There are apparently a few different sub-issues:
- the rcv_wnd is not effectively shared on the tx side, as each subflow takes in account only the value received by the underlaying TCP connection. This is addressed in patch 1/4
- The mptcp-level offered wnd right edge is currently allowed to shrink. Reading section 3.3.4.:
"""
The receive window is relative to the DATA_ACK. As in TCP, a receiver MUST NOT shrink the right edge of the receive window (i.e., DATA_ACK + receive window). The receiver will use the data sequence number to tell if a packet should be accepted at the connection level.
"""
I read the above as we need to reflect window right-edge tracking on the wire, see patch 3/4.
- The offered window right edge tracking can happen concurrently on multiple subflows, but there is no mutex protection. We need an additional atomic operation - still patch 3/4
This series additionally bump a few new MIBs to track all the above (ensure/observe that the suspected races actually take place).
With this series tput in the critical scenario raises from ~26 Gbps (ranging in 4-30 Gbps) to ~43 Gbps (with min > 33 Gbps)
I guess patch 3/4 is the most debatable - expecially for RFC compliance Any feedback more then welcome!
Note: still in patch 3/4, I'm unsure that the th->window update is strictly necessary from functional perspective (e.g. possibly the atomic operation is enough), I'll try to test that, too.
Paolo Abeni (4):
mptcp: really share subflow snd_wnd
mptcp: add mib for xmit window sharing
mptcp: never shrink offered window
mptcp: add more offered MIBs counter.
include/net/mptcp.h | 2 +- net/ipv4/tcp_output.c | 2 +- net/mptcp/mib.c | 4 +++ net/mptcp/mib.h | 6 +++++ net/mptcp/options.c | 61 +++++++++++++++++++++++++++++++++++++------ net/mptcp/protocol.c | 24 +++++++++++------ 6 files changed, 81 insertions(+), 18 deletions(-)
Signature · 1 line
2.35.1