Skip to content

Refactor UMR post send logic

Leon Romanovsky linux-rdma lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12RDMA/mlx5: Move init and cleanup of UMR to umr.cdrivers/infiniband/hw/mlx5/Makefile drivers/infiniband/hw/mlx5/main.c drivers/infiniband/hw/mlx5/umr.c +1 more+125 -1030 replies
2/12RDMA/mlx5: Move umr checks to umr.hdrivers/infiniband/hw/mlx5/mlx5_ib.h drivers/infiniband/hw/mlx5/mr.c drivers/infiniband/hw/mlx5/odp.c +2 more+72 -700 replies
3/12RDMA/mlx5: Move mkey ctrl segment logic to umr.cdrivers/infiniband/hw/mlx5/mlx5_ib.h drivers/infiniband/hw/mlx5/qp.c drivers/infiniband/hw/mlx5/umr.c +2 more+147 -1411 reply
4/12RDMA/mlx5: Simplify get_umr_update_access_mask()drivers/infiniband/hw/mlx5/umr.c+5 -100 replies
5/12RDMA/mlx5: Expose wqe posting helpers outside of wr.cdrivers/infiniband/hw/mlx5/wr.c drivers/infiniband/hw/mlx5/wr.h+121 -1110 replies
6/12RDMA/mlx5: Introduce mlx5_umr_post_send_wait()drivers/infiniband/hw/mlx5/umr.c drivers/infiniband/hw/mlx5/umr.h+104 -00 replies
7/12RDMA/mlx5: Use mlx5_umr_post_send_wait() to revoke MRsdrivers/infiniband/hw/mlx5/mr.c drivers/infiniband/hw/mlx5/umr.c drivers/infiniband/hw/mlx5/umr.h+34 -280 replies
8/12RDMA/mlx5: Use mlx5_umr_post_send_wait() to rereg pd accessdrivers/infiniband/hw/mlx5/mr.c drivers/infiniband/hw/mlx5/umr.c drivers/infiniband/hw/mlx5/umr.h+45 -250 replies
9/12RDMA/mlx5: Move creation and free of translation tables to umr.cdrivers/infiniband/hw/mlx5/mr.c drivers/infiniband/hw/mlx5/umr.c drivers/infiniband/hw/mlx5/umr.h+117 -1001 reply
10/12RDMA/mlx5: Use mlx5_umr_post_send_wait() to update MR pasdrivers/infiniband/hw/mlx5/mlx5_ib.h drivers/infiniband/hw/mlx5/mr.c drivers/infiniband/hw/mlx5/odp.c +2 more+164 -751 reply
11/12RDMA/mlx5: Use mlx5_umr_post_send_wait() to update xltdrivers/infiniband/hw/mlx5/mlx5_ib.h drivers/infiniband/hw/mlx5/mr.c drivers/infiniband/hw/mlx5/odp.c +2 more+117 -2100 replies
12/12RDMA/mlx5: Clean UMR QP type flow from mlx5_ib_post_send()drivers/infiniband/hw/mlx5/mlx5_ib.h drivers/infiniband/hw/mlx5/umr.c drivers/infiniband/hw/mlx5/umr.h +1 more+1 -1450 replies

Reviews trailers per patch

All 12 patches have a Reviewed-by or Acked-by.

PatchMichael Guralnik
1/12R-b
2/12R-b
3/12R-b
4/12R-b
5/12R-b
6/12R-b
7/12R-b
8/12R-b
9/12R-b
10/12R-b
11/12R-b
12/12R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH rdma-next 00/12] Refactor UMR post send logic

From: Leon Romanovsky <[email protected]>

Hi,

UMR are special QPs that require slightly different logic than other QPs. This series from Aharon refactors the logic around UMR QP to separate file and functions to clean the post send flow.

Thanks

Aharon Landau (12):
RDMA/mlx5: Move init and cleanup of UMR to umr.c RDMA/mlx5: Move umr checks to umr.h
RDMA/mlx5: Move mkey ctrl segment logic to umr.c RDMA/mlx5: Simplify get_umr_update_access_mask() RDMA/mlx5: Expose wqe posting helpers outside of wr.c RDMA/mlx5: Introduce mlx5_umr_post_send_wait() RDMA/mlx5: Use mlx5_umr_post_send_wait() to revoke MRs RDMA/mlx5: Use mlx5_umr_post_send_wait() to rereg pd access RDMA/mlx5: Move creation and free of translation tables to umr.c RDMA/mlx5: Use mlx5_umr_post_send_wait() to update MR pas RDMA/mlx5: Use mlx5_umr_post_send_wait() to update xlt RDMA/mlx5: Clean UMR QP type flow from mlx5_ib_post_send()

 drivers/infiniband/hw/mlx5/Makefile  |   1 +
 drivers/infiniband/hw/mlx5/main.c    | 109 +----
 drivers/infiniband/hw/mlx5/mlx5_ib.h |  89 +---
 drivers/infiniband/hw/mlx5/mr.c      | 421 +---------------
 drivers/infiniband/hw/mlx5/odp.c     |  63 ++-
 drivers/infiniband/hw/mlx5/qp.c      |   1 +
 drivers/infiniband/hw/mlx5/umr.c     | 700 +++++++++++++++++++++++++++
 drivers/infiniband/hw/mlx5/umr.h     |  97 ++++
 drivers/infiniband/hw/mlx5/wr.c      | 377 +++------------
 drivers/infiniband/hw/mlx5/wr.h      |  60 +++
 10 files changed, 976 insertions(+), 942 deletions(-)
 create mode 100644 drivers/infiniband/hw/mlx5/umr.c
 create mode 100644 drivers/infiniband/hw/mlx5/umr.h
Signature · 1 line
2.35.1