Skip to content

staging: vt6655: Replace macro VNSvInPortB with ioread8()

Philipp Hortmann linux-staging lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2staging: vt6655: Replace MACvGPIOIn with VNSvInPortBdrivers/staging/vt6655/device_main.c drivers/staging/vt6655/mac.h+1 -40 replies
2/2staging: vt6655: Replace VNSvInPortB with ioread8drivers/staging/vt6655/baseband.c drivers/staging/vt6655/card.c drivers/staging/vt6655/device_main.c +3 more+19 -281 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] staging: vt6655: Replace macro VNSvInPortB with ioread8()

Replace macro VNSvInPortB with ioread8. Avoid cast of the return value is possible with one exception.
The name of macro and the arguments use CamelCase which is not accepted by checkpatch.pl

The one casting exception could be removed by changing bb_read_embedded. Instead of having a unused return value bool the return value could be an unsigned char.

Since there are more than one checkpatch issue per line, more steps are rquired to fix all issues.

This patch series is new but the second patch is already in V4.

Tested with vt6655 on mini PCI Module Transferred this patch over wlan connection of vt6655

Philipp Hortmann (2):
staging: vt6655: Replace MACvGPIOIn with VNSvInPortB
staging: vt6655: Replace VNSvInPortB with ioread8

 drivers/staging/vt6655/baseband.c    |  6 +++---
 drivers/staging/vt6655/card.c        |  2 +-
 drivers/staging/vt6655/device_main.c |  6 +++---
 drivers/staging/vt6655/mac.h         | 27 +++++++++------------------
 drivers/staging/vt6655/srom.c        |  6 +++---
 drivers/staging/vt6655/upc.h         |  3 ---
 6 files changed, 19 insertions(+), 31 deletions(-)
Signature · 1 line
2.25.1

Read the cover letter in its thread